content/browser/android/java/gin_java_method_invocation_helper.cc - Issue 1552733002: Convert Pass()→std::move() in //content (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.cc

Issue 1552733002: Convert Pass()→std::move() in //content (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/in_process/synchronous_compositor_factory_impl.cc ('k') | content/browser/android/java/java_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/java/gin_java_method_invocation_helper.cc

diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc

index 93ab2e662285a0097da57bab4b56e33245019487..5241044770c1a759f3bc2b9b7343a3bc56d50f41 100644

--- a/content/browser/android/java/gin_java_method_invocation_helper.cc

+++ b/content/browser/android/java/gin_java_method_invocation_helper.cc

@@ -5,8 +5,8 @@

#include "content/browser/android/java/gin_java_method_invocation_helper.h"

#include <unistd.h>

#include <cmath>

+#include <utility>

#include "base/android/event_log.h"

#include "base/android/jni_android.h"

@@ -33,11 +33,10 @@ GinJavaMethodInvocationHelper::GinJavaMethodInvocationHelper(

scoped_ptr<ObjectDelegate> object,

const std::string& method_name,

const base::ListValue& arguments)

- : object_(object.Pass()),

+ : object_(std::move(object)),

method_name_(method_name),

arguments_(arguments.DeepCopy()),

- invocation_error_(kGinJavaBridgeNoError) {

+ invocation_error_(kGinJavaBridgeNoError) {}

GinJavaMethodInvocationHelper::~GinJavaMethodInvocationHelper() {}