content/browser/android/in_process/synchronous_compositor_factory_impl.cc - Issue 1552733002: Convert Pass()→std::move() in //content (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/in_process/synchronous_compositor_factory_impl.cc

Issue 1552733002: Convert Pass()→std::move() in //content (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/in_process/context_provider_in_process.cc ('k') | content/browser/android/java/gin_java_method_invocation_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/in_process/synchronous_compositor_factory_impl.cc

diff --git a/content/browser/android/in_process/synchronous_compositor_factory_impl.cc b/content/browser/android/in_process/synchronous_compositor_factory_impl.cc

index d70dce4421119cca9d2826bde2253e2cac444640..628bfccf6a2bec4f243ae8896b6030754f049b69 100644

--- a/content/browser/android/in_process/synchronous_compositor_factory_impl.cc

+++ b/content/browser/android/in_process/synchronous_compositor_factory_impl.cc

@@ -5,6 +5,7 @@

#include "content/browser/android/in_process/synchronous_compositor_factory_impl.h"

#include <stdint.h>

+#include <utility>

#include "base/command_line.h"

#include "base/macros.h"

@@ -77,7 +78,7 @@ ContextHolder CreateContextHolder(

holder.command_buffer =

scoped_ptr<WebGraphicsContext3DInProcessCommandBufferImpl>(

WebGraphicsContext3DInProcessCommandBufferImpl::WrapContext(

- context.Pass(), attributes));

+ std::move(context), attributes));

holder.gl_in_process_context = context_ptr;

return holder;

@@ -240,7 +241,7 @@ SynchronousCompositorFactoryImpl::TryCreateStreamTextureFactory() {

CreateContextHolder(attributes, android_view_service_,

gpu::GLInProcessContextSharedMemoryLimits(), false);

video_context_provider_ = new VideoContextProvider(

- ContextProviderInProcess::Create(holder.command_buffer.Pass(),

+ ContextProviderInProcess::Create(std::move(holder.command_buffer),

"Video-Offscreen-main-thread"),

holder.gl_in_process_context);

}