Fix retargeting of composited smooth scrolls from the main thread.

Fix retargeting of composited smooth scrolls from the main thread.

When we transition to RunningOnCompositorButNeedsUpdate, we need to call
registerForAnimation again to ensure that updateCompositorAnimations is called.
We also cannot rely on m_lastTickTime since we do not get tickAnimation for
composited scrolls.

BUG=571680
Committed: https://crrev.com/ef5777214152eb0bf020be5074e524a8580aa302
Cr-Commit-Position: refs/heads/master@{#367204}

[skobes, 2015-12-30 20:11:19]

skobes@chromium.org changed reviewers:
+ ymalik@chromium.org

[ymalik, 2015-12-30 20:28:08]

lgtm! thanks for looking into this!

[skobes, 2015-12-30 20:38:42]

skobes@chromium.org changed reviewers:
+ jbroman@chromium.org

[skobes, 2015-12-30 20:38:42]

+jbroman for OWNERS

[jbroman, 2015-12-30 20:42:53]

rs lgtm (with one nit)

It would be nice to have a test for the issue this is fixing.

https://codereview.chromium.org/1551933002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/ScrollAnimator.h (right):

https://codereview.chromium.org/1551933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/ScrollAnimator.h:73: bool
registerAndScheduleAnimation();
nit: It's not obvious what returning true or false means in this context;
consider adding a comment.

[skobes, 2015-12-30 20:54:03]

Patchset #3 (id:40001) has been deleted

[skobes, 2015-12-30 20:54:55]

Added TODO for better test coverage.

https://codereview.chromium.org/1551933002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/ScrollAnimator.h (right):

https://codereview.chromium.org/1551933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/ScrollAnimator.h:73: bool
registerAndScheduleAnimation();
On 2015/12/30 20:42:52, jbroman wrote:
> nit: It's not obvious what returning true or false means in this context;
> consider adding a comment.

Done.

[skobes, 2015-12-30 20:55:01]

The CQ bit was checked by skobes@chromium.org

[skobes, 2015-12-30 20:55:02]

The patchset sent to the CQ was uploaded after l-g-t-m from ymalik@chromium.org,
jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1551933002/#ps60001
(title: "address review comment")

[commit-bot: I haz the power, 2015-12-30 20:56:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551933002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551933002/60001

[commit-bot: I haz the power, 2015-12-30 21:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-30 21:18:20]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skobes, 2015-12-30 22:32:38]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2015-12-30 22:33:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551933002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551933002/60001

[commit-bot: I haz the power, 2015-12-30 23:40:40]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-12-30 23:41:45]

Description was changed from

==========
Fix retargeting of composited smooth scrolls from the main thread.

When we transition to RunningOnCompositorButNeedsUpdate, we need to call
registerForAnimation again to ensure that updateCompositorAnimations is called.
We also cannot rely on m_lastTickTime since we do not get tickAnimation for
composited scrolls.

BUG=571680
==========

to

==========
Fix retargeting of composited smooth scrolls from the main thread.

When we transition to RunningOnCompositorButNeedsUpdate, we need to call
registerForAnimation again to ensure that updateCompositorAnimations is called.
We also cannot rely on m_lastTickTime since we do not get tickAnimation for
composited scrolls.

BUG=571680

Committed: https://crrev.com/ef5777214152eb0bf020be5074e524a8580aa302
Cr-Commit-Position: refs/heads/master@{#367204}
==========

[commit-bot: I haz the power, 2015-12-30 23:41:45]

Patchset 3 (id:??) landed as
https://crrev.com/ef5777214152eb0bf020be5074e524a8580aa302
Cr-Commit-Position: refs/heads/master@{#367204}