Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

Issue 1551933002: Fix retargeting of composited smooth scrolls from the main thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.h
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h
index 5d8f20a3f84d00c41494120eae3ec0b660651b00..8bc8caa05225a50162a4d859b4d5a876ab02c5f4 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h
+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h
@@ -65,13 +65,17 @@ public:
protected:
OwnPtr<WebScrollOffsetAnimationCurve> m_animationCurve;
- double m_lastTickTime;
double m_startTime;
WTF::TimeFunction m_timeFunction;
private:
FloatPoint desiredTargetPosition() const;
+ // Returns true if the animation was scheduled successfully. If animation
+ // could not be scheduled (e.g. because the frame is detached), scrolls
+ // immediately to the target and returns false.
+ bool registerAndScheduleAnimation();
+
FloatPoint m_targetOffset;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698