third_party/WebKit/Source/platform/scroll/ScrollAnimator.h - Issue 1551933002: Fix retargeting of composited smooth scrolls from the main thread.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

Issue 1551933002: Fix retargeting of composited smooth scrolls from the main thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2011, Google Inc. All rights reserved.	2 * Copyright (c) 2011, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 void cancelAnimation() override;	58 void cancelAnimation() override;

59 void resetAnimationState() override;	59 void resetAnimationState() override;

60 void updateCompositorAnimations() override;	60 void updateCompositorAnimations() override;

61 void notifyCompositorAnimationFinished(int groupId) override;	61 void notifyCompositorAnimationFinished(int groupId) override;

62 void layerForCompositedScrollingDidChange(WebCompositorAnimationTimeline*) o verride;	62 void layerForCompositedScrollingDidChange(WebCompositorAnimationTimeline*) o verride;

63	63

64 DECLARE_VIRTUAL_TRACE();	64 DECLARE_VIRTUAL_TRACE();

65	65

66 protected:	66 protected:

67 OwnPtr<WebScrollOffsetAnimationCurve> m_animationCurve;	67 OwnPtr<WebScrollOffsetAnimationCurve> m_animationCurve;

68 double m_lastTickTime;

69 double m_startTime;	68 double m_startTime;

70 WTF::TimeFunction m_timeFunction;	69 WTF::TimeFunction m_timeFunction;

71	70

72 private:	71 private:

73 FloatPoint desiredTargetPosition() const;	72 FloatPoint desiredTargetPosition() const;

	73 bool registerAndScheduleAnimation();
	jbroman 2015/12/30 20:42:52 nit: It's not obvious what returning true or false nit: It's not obvious what returning true or false means in this context; consider adding a comment. skobes 2015/12/30 20:54:54 Done. Show quoted text On 2015/12/30 20:42:52, jbroman wrote: > nit: It's not obvious what returning true or false means in this context; > consider adding a comment. Done.
74	74

75 FloatPoint m_targetOffset;	75 FloatPoint m_targetOffset;

76 };	76 };

77	77

78 } // namespace blink	78 } // namespace blink

79	79

80 #endif // ScrollAnimator_h	80 #endif // ScrollAnimator_h

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp » ('j') | no next file with comments »