third_party/android_protobuf/BUILD.gn - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_protobuf/BUILD.gn

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, and no -Wextra for pnacl-clang in gn for now Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/renderer/plugin/plugin.gypi ('K') | « third_party/android_crazy_linker/src/src/crazy_linker_leb128.h ('k') | third_party/android_protobuf/android_protobuf.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/android_protobuf/BUILD.gn

diff --git a/third_party/android_protobuf/BUILD.gn b/third_party/android_protobuf/BUILD.gn

index 266ca83a7ae5631ac756fc16abcefc42b28a0756..73b82a6950c017b18c3a5f9f850e5fa990ff5807 100644

--- a/third_party/android_protobuf/BUILD.gn

+++ b/third_party/android_protobuf/BUILD.gn

@@ -118,6 +118,8 @@ if (current_toolchain == host_toolchain) {

cflags = [

"-Wno-null-conversion",

"-Wno-tautological-undefined-compare",

+ "-Wno-unused-function",

+ "-Wno-unused-local-typedef",

]

}

defines = [