third_party/android_protobuf/android_protobuf.gyp - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_protobuf/android_protobuf.gyp

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, and no -Wextra for pnacl-clang in gn for now Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/android_protobuf/android_protobuf.gyp

diff --git a/third_party/android_protobuf/android_protobuf.gyp b/third_party/android_protobuf/android_protobuf.gyp

index 9d7061bc136b8bedf01e88eeb75747dc0169e9cc..ead49f8edca780bcbb7f3060619e80f5701bb3a4 100644

--- a/third_party/android_protobuf/android_protobuf.gyp

+++ b/third_party/android_protobuf/android_protobuf.gyp

@@ -128,6 +128,8 @@

'cflags': [

'-Wno-null-conversion',

'-Wno-tautological-undefined-compare',

+ '-Wno-unused-function',

+ '-Wno-unused-local-typedef',

'defines': [

# This macro must be defined to suppress the use

« components/nacl/renderer/plugin/plugin.gypi ('K') | « third_party/android_protobuf/BUILD.gn ('k') | third_party/harfbuzz-ng/README.chromium » ('j') | no next file with comments »