third_party/android_crazy_linker/src/src/crazy_linker_leb128.h - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_leb128.h

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, and no -Wextra for pnacl-clang in gn for now Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/renderer/plugin/plugin.gypi ('K') | « ppapi/native_client/src/untrusted/irt_stub/thread_creator.c ('k') | third_party/android_protobuf/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/android_crazy_linker/src/src/crazy_linker_leb128.h

diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_leb128.h b/third_party/android_crazy_linker/src/src/crazy_linker_leb128.h

index 787566e66433b9cb7c10b723b96ffccd80d6c1f3..08bea66ee33c20fcb906c72ffcf954202179a6a5 100644

--- a/third_party/android_crazy_linker/src/src/crazy_linker_leb128.h

+++ b/third_party/android_crazy_linker/src/src/crazy_linker_leb128.h

@@ -15,8 +15,11 @@ namespace crazy {

class Sleb128Decoder {

public:

- Sleb128Decoder(const uint8_t* buffer, size_t count)

- : current_(buffer), end_(buffer + count) { }

+ Sleb128Decoder(const uint8_t* buffer, size_t count) : current_(buffer)

+#ifndef NDEBUG

+ , end_(buffer + count)

+#endif

+ {}

size_t pop_front() {

size_t value = 0;

@@ -42,7 +45,9 @@ class Sleb128Decoder {

private:

const uint8_t* current_;

+#ifndef NDEBUG

const uint8_t* const end_;

+#endif

};

} // namespace crazy