components/nacl/renderer/plugin/plugin.gypi - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/plugin/plugin.gypi

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, and no -Wextra for pnacl-clang in gn for now Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/common.gypi ('K') | « components/history/core/browser/android/android_history_types.h ('k') | content/browser/android/java/gin_java_method_invocation_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/renderer/plugin/plugin.gypi

diff --git a/components/nacl/renderer/plugin/plugin.gypi b/components/nacl/renderer/plugin/plugin.gypi

index e7f31710fb774413bfedd6b83ae659b1a79810ff..ea82a68da9ceaa194539946e1febaf5ed64a348d 100644

--- a/components/nacl/renderer/plugin/plugin.gypi

+++ b/components/nacl/renderer/plugin/plugin.gypi

@@ -33,9 +33,6 @@

'cflags': [

'-Wno-long-long',

- 'cflags!': [

- '-Wno-unused-parameter', # be a bit stricter to match NaCl flags.

Nico 2015/12/30 22:53:26 This had no effect, because -Wunused-parameter is

- ],

'conditions': [

['asan!=1 and msan!=1 and ubsan_vptr!=1', {

'ldflags': [