Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550383002: Convert Pass()→std::move() in //components (Android edition) (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //components (Android edition) (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=jochen@chromium.org Committed: https://crrev.com/d0cf8b99e51ec3695b944fd803437a2ea5989b08 Cr-Commit-Position: refs/heads/master@{#367127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -74 lines) Patch
M components/crash/content/browser/crash_dump_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/chromium_url_request_context.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/cronet/android/cronet_in_memory_pref_store.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/cronet/android/cronet_upload_data_stream_adapter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/cronet/android/cronet_url_request_adapter.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M components/cronet/android/test/native_test_server.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M components/cronet/android/test/test_upload_data_stream_handler.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/cronet/android/url_request_adapter.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M components/cronet/android/url_request_context_adapter.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M components/data_usage/android/traffic_stats_amortizer.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/data_usage/android/traffic_stats_amortizer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/policy/core/browser/android/android_combined_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/android/policy_converter.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M components/safe_json/safe_json_parser_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/sessions/core/in_memory_tab_restore_service.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/translate/core/browser/translate_infobar_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for general review / sanity check +jochen for OWNERS review
4 years, 11 months ago (2015-12-30 00:09:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550383002/1
4 years, 11 months ago (2015-12-30 00:12:25 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-30 00:29:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 01:13:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550383002/1
4 years, 11 months ago (2015-12-30 01:45:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 01:51:56 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 01:52:55 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d0cf8b99e51ec3695b944fd803437a2ea5989b08
Cr-Commit-Position: refs/heads/master@{#367127}

Powered by Google App Engine
This is Rietveld 408576698