components/cronet/url_request_context_config.cc - Issue 1550383002: Convert Pass()→std::move() in //components (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/url_request_context_config.cc

Issue 1550383002: Convert Pass()→std::move() in //components (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/url_request_context_adapter.cc ('k') | components/data_usage/android/traffic_stats_amortizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/url_request_context_config.cc

diff --git a/components/cronet/url_request_context_config.cc b/components/cronet/url_request_context_config.cc

index 32b845c753a216f2fe293b95af98a21e16945393..892fd578dc341e083e50130329dcd210bc285f9a 100644

--- a/components/cronet/url_request_context_config.cc

+++ b/components/cronet/url_request_context_config.cc

@@ -4,6 +4,8 @@

#include "components/cronet/url_request_context_config.h"

+#include <utility>

#include "base/json/json_reader.h"

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

@@ -55,7 +57,7 @@ void ParseAndSetExperimentalOptions(

}

scoped_ptr<base::DictionaryValue> dict =

- base::DictionaryValue::From(options.Pass());

+ base::DictionaryValue::From(std::move(options));

if (!dict) {

DCHECK(false) << "Experimental options string is not a dictionary: "

@@ -200,7 +202,7 @@ void URLRequestContextConfig::ConfigureURLRequestContextBuilder(

net_log);

if (mock_cert_verifier)

- context_builder->SetCertVerifier(mock_cert_verifier.Pass());

+ context_builder->SetCertVerifier(std::move(mock_cert_verifier));

// TODO(mef): Use |config| to set cookies.

}