components/cronet/android/cronet_in_memory_pref_store.cc - Issue 1550383002: Convert Pass()→std::move() in //components (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_in_memory_pref_store.cc

Issue 1550383002: Convert Pass()→std::move() in //components (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/chromium_url_request_context.cc ('k') | components/cronet/android/cronet_upload_data_stream_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_in_memory_pref_store.cc

diff --git a/components/cronet/android/cronet_in_memory_pref_store.cc b/components/cronet/android/cronet_in_memory_pref_store.cc

index 43a484b1da88f0d1dd70461307a8c106af11e7ee..3bf641faa9e463983fe784edfbd03e05b15b8afb 100644

--- a/components/cronet/android/cronet_in_memory_pref_store.cc

+++ b/components/cronet/android/cronet_in_memory_pref_store.cc

@@ -4,6 +4,8 @@

#include "components/cronet/android/cronet_in_memory_pref_store.h"

+#include <utility>

#include "base/logging.h"

#include "base/values.h"

@@ -41,14 +43,14 @@ void CronetInMemoryPrefStore::SetValue(const std::string& key,

scoped_ptr<base::Value> value,

uint32_t flags) {

DCHECK(value);

- if (prefs_.SetValue(key, value.Pass()))

+ if (prefs_.SetValue(key, std::move(value)))

ReportValueChanged(key, flags);

}

void CronetInMemoryPrefStore::SetValueSilently(const std::string& key,

scoped_ptr<base::Value> value,

uint32_t flags) {

- prefs_.SetValue(key, value.Pass());

+ prefs_.SetValue(key, std::move(value));

}

void CronetInMemoryPrefStore::RemoveValue(const std::string& key,