components/cronet/android/chromium_url_request_context.cc - Issue 1550383002: Convert Pass()→std::move() in //components (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/chromium_url_request_context.cc

Issue 1550383002: Convert Pass()→std::move() in //components (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/crash/content/browser/crash_dump_manager_android.cc ('k') | components/cronet/android/cronet_in_memory_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/chromium_url_request_context.cc

diff --git a/components/cronet/android/chromium_url_request_context.cc b/components/cronet/android/chromium_url_request_context.cc

index 3969ec0cfd99d48b7d797f780afad294b4db1e98..05233bef423acb84ceaef93bcb39a93ec612f8d8 100644

--- a/components/cronet/android/chromium_url_request_context.cc

+++ b/components/cronet/android/chromium_url_request_context.cc

@@ -5,6 +5,7 @@

#include "components/cronet/android/chromium_url_request_context.h"

#include <string>

+#include <utility>

#include "base/android/jni_android.h"

#include "base/android/jni_string.h"

@@ -80,7 +81,7 @@ static jlong CreateRequestContextAdapter(

URLRequestContextAdapter* context_adapter = new URLRequestContextAdapter(

new JniURLRequestContextAdapterDelegate(env, jcaller), user_agent);

context_adapter->AddRef(); // Hold onto this ref-counted object.

- context_adapter->Initialize(context_config.Pass());

+ context_adapter->Initialize(std::move(context_config));

return reinterpret_cast<jlong>(context_adapter);

}