Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1548783002: Adding details to most quic connection close calls. (Closed)

Created:
5 years ago by Fan Yang
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@110540464
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding details to most quic connection close calls. This is a precursor to removing CloseConnection[without details] entirely. This is so we can to be able disambiguate various causes of specific error codes when logging them server side. We can always add more details where useful at a later point. Merge internal change: 110546286 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -110 lines) Patch
M net/quic/crypto/crypto_framer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_framer.cc View 7 chunks +9 lines, -3 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +6 lines, -2 lines 0 comments Download
M net/quic/quic_connection.cc View 12 chunks +26 lines, -21 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 6 chunks +13 lines, -6 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/quic_flow_controller_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.cc View 8 chunks +20 lines, -9 lines 0 comments Download
M net/quic/quic_session_test.cc View 10 chunks +18 lines, -15 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Fan Yang
5 years ago (2015-12-22 21:29:10 UTC) #1
Ryan Hamilton
5 years ago (2015-12-22 22:01:55 UTC) #2
LGTM, though the BUG= lines are showing the internal bug numbers, not the
chromium bug numbers, so we should probably remove them from the CL Chromium
descriptions. (Probably should update the docs)

Powered by Google App Engine
This is Rietveld 408576698