Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 1548783002: Adding details to most quic connection close calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@110540464
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_server_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index b66db913fd805200eefcf1d7a08ceb5320d8fb47..221efda9d8c5b7cb1a64f564623294b66d32947f 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -126,8 +126,8 @@ QuicServerSession* CreateSession(QuicDispatcher* dispatcher,
new MockServerConnection(connection_id, helper, dispatcher);
*session = new TestQuicSpdyServerSession(config, connection, crypto_config);
connection->set_visitor(*session);
- ON_CALL(*connection, SendConnectionClose(_)).WillByDefault(
- WithoutArgs(Invoke(
+ ON_CALL(*connection, SendConnectionCloseWithDetails(_, _))
+ .WillByDefault(WithoutArgs(Invoke(
connection, &MockServerConnection::UnregisterOnConnectionClosed)));
EXPECT_CALL(*reinterpret_cast<MockConnection*>((*session)->connection()),
ProcessUdpPacket(_, client_address, _));
@@ -253,7 +253,7 @@ TEST_F(QuicDispatcherTest, Shutdown) {
ProcessPacket(client_address, 1, true, "foo");
EXPECT_CALL(*reinterpret_cast<MockConnection*>(session1_->connection()),
- SendConnectionClose(QUIC_PEER_GOING_AWAY));
+ SendConnectionCloseWithDetails(QUIC_PEER_GOING_AWAY, _));
dispatcher_.Shutdown();
}
@@ -597,8 +597,10 @@ class QuicDispatcherWriteBlockedListTest : public QuicDispatcherTest {
}
void TearDown() override {
- EXPECT_CALL(*connection1(), SendConnectionClose(QUIC_PEER_GOING_AWAY));
- EXPECT_CALL(*connection2(), SendConnectionClose(QUIC_PEER_GOING_AWAY));
+ EXPECT_CALL(*connection1(),
+ SendConnectionCloseWithDetails(QUIC_PEER_GOING_AWAY, _));
+ EXPECT_CALL(*connection2(),
+ SendConnectionCloseWithDetails(QUIC_PEER_GOING_AWAY, _));
dispatcher_.Shutdown();
}
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_server_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698