Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 1548783002: Adding details to most quic connection close calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@110540464
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/reliable_quic_stream.cc ('k') | net/tools/quic/quic_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream_test.cc
diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc
index 6f7228137a4d50d102be2771f70e22175cba3ed8..55e1a50fc04e7c595e48bb2c701a9de0fa31a47e 100644
--- a/net/quic/reliable_quic_stream_test.cc
+++ b/net/quic/reliable_quic_stream_test.cc
@@ -606,8 +606,8 @@ TEST_F(ReliableQuicStreamTest,
stream_->flow_controller()));
// Stream should not accept the frame, and the connection should be closed.
- EXPECT_CALL(*connection_,
- SendConnectionClose(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA));
+ EXPECT_CALL(*connection_, SendConnectionCloseWithDetails(
+ QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA, _));
stream_->OnStreamFrame(frame);
}
@@ -619,8 +619,8 @@ TEST_F(ReliableQuicStreamTest, StopReadingSendsFlowControl) {
stream_->StopReading();
// Connection should not get terminated due to flow control errors.
- EXPECT_CALL(*connection_,
- SendConnectionClose(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA))
+ EXPECT_CALL(*connection_, SendConnectionCloseWithDetails(
+ QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA, _))
.Times(0);
EXPECT_CALL(*connection_, SendWindowUpdate(_, _)).Times(AtLeast(1));
@@ -731,7 +731,7 @@ TEST_F(ReliableQuicStreamTest, EarlyResponseFinHandling) {
// the request, the received FIN is recorded.
Initialize(kShouldProcessData);
- EXPECT_CALL(*connection_, SendConnectionClose(_)).Times(0);
+ EXPECT_CALL(*connection_, SendConnectionCloseWithDetails(_, _)).Times(0);
EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _))
.WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
« no previous file with comments | « net/quic/reliable_quic_stream.cc ('k') | net/tools/quic/quic_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698