Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: net/quic/quic_connection.h

Issue 1548783002: Adding details to most quic connection close calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@110540464
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/crypto_framer.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index f59ed5547f3ccdeb9a656807fa4d499a6f3c153b..6c659a919412f8b52acd091d660df6529ae6feb1 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -697,10 +697,14 @@ class NET_EXPORT_PRIVATE QuicConnection
bool WritePacketInner(QueuedPacket* packet);
// Make sure an ack we got from our peer is sane.
- bool ValidateAckFrame(const QuicAckFrame& incoming_ack);
+ // Returns nullptr for valid acks or an error std::string if it was invalid.
+ const char* ValidateAckFrame(const QuicAckFrame& incoming_ack);
// Make sure a stop waiting we got from our peer is sane.
- bool ValidateStopWaitingFrame(const QuicStopWaitingFrame& stop_waiting);
+ // Returns nullptr if the frame is valid or an error std::string if it was
+ // invalid.
+ const char* ValidateStopWaitingFrame(
+ const QuicStopWaitingFrame& stop_waiting);
// Sends a version negotiation packet to the peer.
void SendVersionNegotiationPacket();
« no previous file with comments | « net/quic/crypto/crypto_framer.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698