GN: Properly mark all NaCl test depencies as data_deps

GN: Properly mark all NaCl test depencies as data_deps

NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.

BUG=462791
Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
Cr-Commit-Position: refs/heads/master@{#367367}

[Petr Hosek, 2015-12-22 01:05:24]

Description was changed from

==========
GN: Properly mark all NaCl test depencies as data_deps

NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.

BUG=462791
==========

to

==========
GN: Properly mark all NaCl test depencies as data_deps

NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.

BUG=462791
==========

[Petr Hosek, 2015-12-22 01:05:24]

phosek@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-12-22 06:53:37]

https://codereview.chromium.org/1547463004/diff/1/chrome/installer/linux/BUIL...
File chrome/installer/linux/BUILD.gn (right):

https://codereview.chromium.org/1547463004/diff/1/chrome/installer/linux/BUIL...
chrome/installer/linux/BUILD.gn:171: "//components/nacl/loader:helper_nonsfi",
Are you sure this is right? I didn't think nonsfi NaCl goes into the Linux
installer.

[Petr Hosek, 2015-12-22 06:55:31]

https://codereview.chromium.org/1547463004/diff/1/chrome/installer/linux/BUIL...
File chrome/installer/linux/BUILD.gn (right):

https://codereview.chromium.org/1547463004/diff/1/chrome/installer/linux/BUIL...
chrome/installer/linux/BUILD.gn:171: "//components/nacl/loader:helper_nonsfi",
On 2015/12/22 06:53:37, brettw wrote:
> Are you sure this is right? I didn't think nonsfi NaCl goes into the Linux
> installer.

You're right, this one is incorrect.

[Petr Hosek, 2015-12-22 07:12:59]

https://codereview.chromium.org/1547463004/diff/1/chrome/installer/linux/BUIL...
File chrome/installer/linux/BUILD.gn (right):

https://codereview.chromium.org/1547463004/diff/1/chrome/installer/linux/BUIL...
chrome/installer/linux/BUILD.gn:171: "//components/nacl/loader:helper_nonsfi",
On 2015/12/22 06:53:37, brettw wrote:
> Are you sure this is right? I didn't think nonsfi NaCl goes into the Linux
> installer.

Done.

[brettw, 2015-12-22 17:57:52]

lgtm

[Petr Hosek, 2015-12-22 17:58:11]

The CQ bit was checked by phosek@chromium.org

[commit-bot: I haz the power, 2015-12-22 17:58:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547463004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547463004/20001

[commit-bot: I haz the power, 2015-12-22 18:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-22 18:06:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Petr Hosek, 2015-12-22 18:38:34]

phosek@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Petr Hosek, 2015-12-22 18:38:49]

Brad, could you please ptal?

[Petr Hosek, 2015-12-29 14:50:24]

ping

[bradnelson, 2016-01-04 17:59:48]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-01-04 17:59:48]

lgtm

[commit-bot: I haz the power, 2016-01-04 18:00:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547463004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547463004/20001

[commit-bot: I haz the power, 2016-01-04 21:08:29]

Description was changed from

==========
GN: Properly mark all NaCl test depencies as data_deps

NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.

BUG=462791
==========

to

==========
GN: Properly mark all NaCl test depencies as data_deps

NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.

BUG=462791
==========

[commit-bot: I haz the power, 2016-01-04 21:08:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-04 21:09:47]

Description was changed from

==========
GN: Properly mark all NaCl test depencies as data_deps

NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.

BUG=462791
==========

to

==========
GN: Properly mark all NaCl test depencies as data_deps

NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.

BUG=462791

Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
Cr-Commit-Position: refs/heads/master@{#367367}
==========

[commit-bot: I haz the power, 2016-01-04 21:09:48]

Patchset 2 (id:??) landed as
https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
Cr-Commit-Position: refs/heads/master@{#367367}

[Dan Beam, 2016-01-04 22:49:11]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1555223002/ by dbeam@chromium.org.

The reason for reverting is: broke windows GN build:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754...

E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64
"--args=is_debug=false is_component_build=false use_goma=true
goma_dir=\"E:\b\build\goma\" symbol_level=1" --check
  -> returned 1
ERROR Input to target not generated by a dependency.
The file:
  //out/Release_x64/nacl_irt_x86_64.nexe
is listed as an input or source for the target:
  //chrome/installer/mini_installer:archive(//build/toolchain/win:x64)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
  //ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64).