extensions/shell/BUILD.gn - Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/BUILD.gn

Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nacl_helper_nonsfi is not part of Linux installer Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/BUILD.gn

diff --git a/extensions/shell/BUILD.gn b/extensions/shell/BUILD.gn

index 0f8af6e169dd8ec4c95f189612edc2670333bacb..8cb0dd35b050d80e7d1a8bbfc23d72030441e93f 100644

--- a/extensions/shell/BUILD.gn

+++ b/extensions/shell/BUILD.gn

@@ -104,7 +104,10 @@ source_set("app_shell_lib") {

]

if (is_linux) {

- deps += [ "//components/nacl/loader:nacl_helper" ]

+ deps += [

+ "//components/nacl/loader:helper_nonsfi",

+ "//components/nacl/loader:nacl_helper",

+ ]

}

« no previous file with comments | « components/nacl/loader/BUILD.gn ('k') | ppapi/BUILD.gn » ('j') | no next file with comments »