Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2461)

Unified Diff: chrome/test/data/nacl/BUILD.gn

Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nacl_helper_nonsfi is not part of Linux installer Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | components/nacl/loader/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/nacl/BUILD.gn
diff --git a/chrome/test/data/nacl/BUILD.gn b/chrome/test/data/nacl/BUILD.gn
index bfec5fb8c98dafdfe23c6867d17ba6eac713636c..b8e80bffa2748ff16103226bb1e0d347ebab64bd 100644
--- a/chrome/test/data/nacl/BUILD.gn
+++ b/chrome/test/data/nacl/BUILD.gn
@@ -9,7 +9,7 @@ group("nacl") {
newlib = "//build/toolchain/nacl:clang_newlib_${target_cpu}"
glibc = "//build/toolchain/nacl:glibc_${target_cpu}"
pnacl = "//build/toolchain/nacl:newlib_pnacl"
- deps = [
+ data_deps = [
":exit_status_test($glibc)",
":exit_status_test($newlib)",
":exit_status_test($pnacl)",
@@ -74,13 +74,13 @@ group("nacl") {
]
if (is_linux) {
nonsfi = "//build/toolchain/nacl:newlib_pnacl_nonsfi"
- deps += [
+ data_deps += [
":irt_exception_test($nonsfi)",
":irt_manifest_file($nonsfi)",
":shared_test_files($nonsfi)",
]
if (is_clang) {
- deps += [ ":nonsfi_libc_free" ]
+ data_deps += [ ":nonsfi_libc_free" ]
}
}
}
« no previous file with comments | « chrome/test/BUILD.gn ('k') | components/nacl/loader/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698