chrome/test/BUILD.gn - Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nacl_helper_nonsfi is not part of Linux installer Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index 9cdb921567e340fe24f2518fa8db5fe9a27e118d..b0810f936bbc6e14ed58c6f149cfd77790966be7 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -984,7 +984,7 @@ if (!is_android) {

}

if (is_win || is_linux) {

sources += [ "../browser/nacl_host/test/nacl_gdb_browsertest.cc" ]

- deps += [ "//chrome/browser/nacl_host/test:mock_nacl_gdb" ]

+ data_deps += [ "//chrome/browser/nacl_host/test:mock_nacl_gdb" ]

}

if (is_win) {

# TODO(halyavin) NaCl on Windows can't open debug stub socket in

« no previous file with comments | « no previous file | chrome/test/data/nacl/BUILD.gn » ('j') | no next file with comments »