Site Settings: Give each category its own route.

chrome/browser/resources/settings/privacy_page/privacy_page.html

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 7d32b89b6f401a97959fea78d0e8850014f2245c..414d6c6b4d7849e2b5c8914bdcd391ed34de4545 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -102,7 +102,40 @@
             prefs="{{prefs}}" category-selected="{{categorySelected}}">

[tommycli, 2016/01/06 19:10:34]

I also noticed that you have this 'categorySelected' property. Once we get the
URL routing done correctly, I think the selected category can just be passed via
the URL/route, and we can eliminate this property.

[Finnur, 2016/01/07 13:14:49]

Eliminated.

         </settings-site-settings-page>
       </neon-animatable>
-      <neon-animatable id="site-settings-category">
+
+      <neon-animatable id="site-settings-category-camera">
+        <settings-subheader i18n-values="page-title:siteSettings">
+        </settings-subheader>
+        <site-settings-category
+            selected-origin="{{originSelected}}" prefs="{{prefs}}"
+            current-route="{{currentRoute}}" category="{{categorySelected}}">

[tommycli, 2016/01/06 19:10:34]

Here you are passing in the categorySelected variable, which is a number.

Instead, i think you should be passing in a string constant, i.e.
category="camera" and same below.

[Finnur, 2016/01/07 13:14:49]

Numbers also work and I think are more appropriate here than a string -- that
anyway needs to be converted into a number before being used. |category| is also
defined as a number.

+        </site-settings-category>
+      </neon-animatable>
+      <neon-animatable id="site-settings-category-cookies">
+        <settings-subheader i18n-values="page-title:siteSettings">
+        </settings-subheader>
+        <site-settings-category
+            selected-origin="{{originSelected}}" prefs="{{prefs}}"
+            current-route="{{currentRoute}}" category="{{categorySelected}}">
+        </site-settings-category>
+      </neon-animatable>
+      <neon-animatable id="site-settings-category-fullscreen">
+        <settings-subheader i18n-values="page-title:siteSettings">
+        </settings-subheader>
+        <site-settings-category
+            selected-origin="{{originSelected}}" prefs="{{prefs}}"
+            current-route="{{currentRoute}}" category="{{categorySelected}}">
+        </site-settings-category>
+      </neon-animatable>
+      <neon-animatable id="site-settings-category-images">
+        <settings-subheader i18n-values="page-title:siteSettings">
+        </settings-subheader>
+        <site-settings-category
+            selected-origin="{{originSelected}}" prefs="{{prefs}}"
+            current-route="{{currentRoute}}" category="{{categorySelected}}">
+        </site-settings-category>
+      </neon-animatable>
+      <neon-animatable id="site-settings-category-location">
         <settings-subheader i18n-values="page-title:siteSettings">
         </settings-subheader>
         <site-settings-category
@@ -110,6 +143,39 @@
             current-route="{{currentRoute}}" category="{{categorySelected}}">
         </site-settings-category>
       </neon-animatable>
+      <neon-animatable id="site-settings-category-javascript">
+        <settings-subheader i18n-values="page-title:siteSettings">
+        </settings-subheader>
+        <site-settings-category
+            selected-origin="{{originSelected}}" prefs="{{prefs}}"
+            current-route="{{currentRoute}}" category="{{categorySelected}}">
+        </site-settings-category>
+      </neon-animatable>
+      <neon-animatable id="site-settings-category-microphone">
+        <settings-subheader i18n-values="page-title:siteSettings">
+        </settings-subheader>
+        <site-settings-category
+            selected-origin="{{originSelected}}" prefs="{{prefs}}"
+            current-route="{{currentRoute}}" category="{{categorySelected}}">
+        </site-settings-category>
+      </neon-animatable>
+      <neon-animatable id="site-settings-category-notifications">
+        <settings-subheader i18n-values="page-title:siteSettings">
+        </settings-subheader>
+        <site-settings-category
+            selected-origin="{{originSelected}}" prefs="{{prefs}}"
+            current-route="{{currentRoute}}" category="{{categorySelected}}">
+        </site-settings-category>
+      </neon-animatable>
+      <neon-animatable id="site-settings-category-popups">
+        <settings-subheader i18n-values="page-title:siteSettings">
+        </settings-subheader>
+        <site-settings-category
+            selected-origin="{{originSelected}}" prefs="{{prefs}}"
+            current-route="{{currentRoute}}" category="{{categorySelected}}">
+        </site-settings-category>
+      </neon-animatable>
+
       <neon-animatable id="site-details">
         <site-details prefs="{{prefs}}" origin="{{originSelected}}">
         </site-details>