Site Settings: Give each category its own route.

chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Index: chrome/browser/resources/settings/site_settings/site_settings_behavior.js
diff --git a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
index b46f6f326e3a58fee2a801e4fe4bd121237a83f9..060b3807477a0a2d3430aed818b57b2732ce0afb 100644
--- a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
+++ b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
@@ -70,6 +70,68 @@ var SiteSettingsBehaviorImpl = {
   },
 
   /**
+   * A utility function to lookup a category name from its enum.

[Finnur, 2016/01/06 14:53:46]

It is easier to review this file if you don't look at what changed since last
uploaded patch but the diff from trunk, as in:
https://codereview.chromium.org/1546993003/diff/40001/chrome/browser/resource...

+   * @param {number} category The category ID to look up.
+   * @return {string} The category found or blank string if not found.
+   * @protected
+   */
+  computeCategoryTextId: function(category) {
+    switch (category) {
+      case settings.ContentSettingsTypes.CAMERA:
+        return 'camera';
+      case settings.ContentSettingsTypes.COOKIES:
+        return 'cookies';
+      case settings.ContentSettingsTypes.FULLSCREEN:
+        return 'fullscreen';
+      case settings.ContentSettingsTypes.GEOLOCATION:
+        return 'location';
+      case settings.ContentSettingsTypes.IMAGES:
+        return 'images';
+      case settings.ContentSettingsTypes.JAVASCRIPT:
+        return 'javascript';
+      case settings.ContentSettingsTypes.MIC:
+        return 'microphone';
+      case settings.ContentSettingsTypes.NOTIFICATIONS:
+        return 'notifications';
+      case settings.ContentSettingsTypes.POPUPS:
+        return 'popups';
+      default:
+        return '';
+    }
+  },
+
+  /**
+   * A utility function to lookup a category enum from its text id.
+   * @param {string} textId The category text id to look up.
+   * @return {number} The category found or -1 if not found.
+   * @protected
+   */
+  computeCategoryFromTextId: function(textId) {
+    switch (textId) {
+      case 'camera':
+        return settings.ContentSettingsTypes.CAMERA;
+      case 'cookies':
+        return settings.ContentSettingsTypes.COOKIES;
+      case 'fullscreen':
+        return settings.ContentSettingsTypes.FULLSCREEN;
+      case 'location':
+        return settings.ContentSettingsTypes.GEOLOCATION;
+      case 'images':
+        return settings.ContentSettingsTypes.IMAGES;
+      case 'javascript':
+        return settings.ContentSettingsTypes.JAVASCRIPT;
+      case 'microphone':
+        return settings.ContentSettingsTypes.MIC;
+      case 'notifications':
+        return settings.ContentSettingsTypes.NOTIFICATIONS;
+      case 'popups':
+        return settings.ContentSettingsTypes.POPUPS;
+      default:
+        return -1;
+    }
+  },
+
+  /**
    * A utility function to compute the icon to use for the category.
    * @param {number} category The category to show the icon for.
    * @return {string} The id of the icon for the given category.
@@ -91,7 +153,7 @@ var SiteSettingsBehaviorImpl = {
         return 'icons:input';
       case settings.ContentSettingsTypes.MIC:
         return 'av:mic';
-      case settings.ContentSettingsTypes.NOTIFICATION:
+      case settings.ContentSettingsTypes.NOTIFICATIONS:
         return 'social:notifications';
       case settings.ContentSettingsTypes.POPUPS:
         return 'icons:open-in-new';
@@ -123,7 +185,7 @@ var SiteSettingsBehaviorImpl = {
         return loadTimeData.getString('siteSettingsJavascript');
       case settings.ContentSettingsTypes.MIC:
         return loadTimeData.getString('siteSettingsMic');
-      case settings.ContentSettingsTypes.NOTIFICATION:
+      case settings.ContentSettingsTypes.NOTIFICATIONS:
         return loadTimeData.getString('siteSettingsNotifications');
       case settings.ContentSettingsTypes.POPUPS:
         return loadTimeData.getString('siteSettingsPopups');
@@ -179,7 +241,7 @@ var SiteSettingsBehaviorImpl = {
         return 'javascript';
       case settings.ContentSettingsTypes.MIC:
         return 'media_stream_mic';
-      case settings.ContentSettingsTypes.NOTIFICATION:
+      case settings.ContentSettingsTypes.NOTIFICATIONS:
         return 'notifications';
       case settings.ContentSettingsTypes.POPUPS:
         return 'popups';
@@ -216,7 +278,7 @@ var SiteSettingsBehaviorImpl = {
         return showRecommendation ?
             loadTimeData.getString('siteSettingsBlockedRecommended') :
             loadTimeData.getString('siteSettingsBlocked');
-      case settings.ContentSettingsTypes.NOTIFICATION:
+      case settings.ContentSettingsTypes.NOTIFICATIONS:
         // "Ask before sending (recommended)" vs "Blocked".
         if (!categoryEnabled) {
           return loadTimeData.getString('siteSettingsBlocked');