Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback and add some tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_router.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_router.js b/chrome/browser/resources/settings/settings_page/settings_router.js
index 81d9f613387139ca8c35423f0946dd09ec75645e..545d786675b7e9b552ee10ba4838c25169e1e2e1 100644
--- a/chrome/browser/resources/settings/settings_page/settings_router.js
+++ b/chrome/browser/resources/settings/settings_page/settings_router.js
@@ -142,11 +142,67 @@ Polymer({
subpageTitles: ['siteSettings'],
},
{
- url: '/siteSettings/category',
+ url: '/siteSettings/category/camera',
page: 'advanced',
section: 'privacy',
- subpage: ['site-settings', 'site-settings-category'],
- subpageTitles: ['siteSettings', 'siteSettingsCategoryPageTitle'],
+ subpage: ['site-settings', 'site-settings-category-camera'],
+ subpageTitles: ['siteSettings', 'siteSettingsCamera'],
+ },
+ {
+ url: '/siteSettings/category/cookies',
+ page: 'advanced',
+ section: 'privacy',
+ subpage: ['site-settings', 'site-settings-category-cookies'],
+ subpageTitles: ['siteSettings', 'siteSettingsCategoryCookies'],
+ },
+ {
+ url: '/siteSettings/category/fullscreen',
+ page: 'advanced',
+ section: 'privacy',
+ subpage: ['site-settings', 'site-settings-category-fullscreen'],
+ subpageTitles: ['siteSettings', 'siteSettingsCategoryFullscreen'],
+ },
+ {
+ url: '/siteSettings/category/images',
+ page: 'advanced',
+ section: 'privacy',
+ subpage: ['site-settings', 'site-settings-category-images'],
+ subpageTitles: ['siteSettings', 'siteSettingsCategoryImages'],
+ },
+ {
+ url: '/siteSettings/category/location',
+ page: 'advanced',
+ section: 'privacy',
+ subpage: ['site-settings', 'site-settings-category-location'],
+ subpageTitles: ['siteSettings', 'siteSettingsCategoryLocation'],
+ },
+ {
+ url: '/siteSettings/category/javascript',
+ page: 'advanced',
+ section: 'privacy',
+ subpage: ['site-settings', 'site-settings-category-javascript'],
+ subpageTitles: ['siteSettings', 'siteSettingsCategoryJavascript'],
+ },
+ {
+ url: '/siteSettings/category/microphone',
+ page: 'advanced',
+ section: 'privacy',
+ subpage: ['site-settings', 'site-settings-category-microphone'],
+ subpageTitles: ['siteSettings', 'siteSettingsCategoryMicrophone'],
+ },
+ {
+ url: '/siteSettings/category/notifications',
+ page: 'advanced',
+ section: 'privacy',
+ subpage: ['site-settings', 'site-settings-category-notifications'],
+ subpageTitles: ['siteSettings', 'siteSettingsCategoryNotifications'],
+ },
+ {
+ url: '/siteSettings/category/popups',
+ page: 'advanced',
+ section: 'privacy',
+ subpage: ['site-settings', 'site-settings-category-popups'],
+ subpageTitles: ['siteSettings', 'siteSettingsCategoryPopups'],
},
{
url: '/siteSettings/category/details',

Powered by Google App Engine
This is Rietveld 408576698