Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback and add some tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item-b ody.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item-b ody.html">
7 <link rel="import" href="chrome://md-settings/certificate_manager_page/certifica te_manager_page.html"> 7 <link rel="import" href="chrome://md-settings/certificate_manager_page/certifica te_manager_page.html">
8 <link rel="import" href="chrome://md-settings/clear_browsing_data_page/clear_bro wsing_data_page.html"> 8 <link rel="import" href="chrome://md-settings/clear_browsing_data_page/clear_bro wsing_data_page.html">
9 <link rel="import" href="chrome://md-settings/controls/settings_checkbox.html"> 9 <link rel="import" href="chrome://md-settings/controls/settings_checkbox.html">
10 <link rel="import" href="chrome://md-settings/settings_page/settings_animated_pa ges.html"> 10 <link rel="import" href="chrome://md-settings/settings_page/settings_animated_pa ges.html">
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 <neon-animatable id="manage-certificates"> 92 <neon-animatable id="manage-certificates">
93 <settings-subheader i18n-values="page-title:manageCertificates"> 93 <settings-subheader i18n-values="page-title:manageCertificates">
94 </settings-subheader> 94 </settings-subheader>
95 <settings-certificate-manager-page> 95 <settings-certificate-manager-page>
96 </settings-certificate-manager-page> 96 </settings-certificate-manager-page>
97 </neon-animatable> 97 </neon-animatable>
98 <neon-animatable id="site-settings"> 98 <neon-animatable id="site-settings">
99 <settings-subheader i18n-values="page-title:siteSettings"> 99 <settings-subheader i18n-values="page-title:siteSettings">
100 </settings-subheader> 100 </settings-subheader>
101 <settings-site-settings-page current-route="{{currentRoute}}" 101 <settings-site-settings-page current-route="{{currentRoute}}"
102 prefs="{{prefs}}" category-selected="{{categorySelected}}"> 102 prefs="{{prefs}}" category-selected="{{categorySelected}}">
tommycli 2016/01/06 19:10:34 I also noticed that you have this 'categorySelecte
Finnur 2016/01/07 13:14:49 Eliminated.
103 </settings-site-settings-page> 103 </settings-site-settings-page>
104 </neon-animatable> 104 </neon-animatable>
105 <neon-animatable id="site-settings-category"> 105
106 <neon-animatable id="site-settings-category-camera">
106 <settings-subheader i18n-values="page-title:siteSettings"> 107 <settings-subheader i18n-values="page-title:siteSettings">
107 </settings-subheader> 108 </settings-subheader>
108 <site-settings-category 109 <site-settings-category
110 selected-origin="{{originSelected}}" prefs="{{prefs}}"
111 current-route="{{currentRoute}}" category="{{categorySelected}}">
tommycli 2016/01/06 19:10:34 Here you are passing in the categorySelected varia
Finnur 2016/01/07 13:14:49 Numbers also work and I think are more appropriate
112 </site-settings-category>
113 </neon-animatable>
114 <neon-animatable id="site-settings-category-cookies">
115 <settings-subheader i18n-values="page-title:siteSettings">
116 </settings-subheader>
117 <site-settings-category
118 selected-origin="{{originSelected}}" prefs="{{prefs}}"
119 current-route="{{currentRoute}}" category="{{categorySelected}}">
120 </site-settings-category>
121 </neon-animatable>
122 <neon-animatable id="site-settings-category-fullscreen">
123 <settings-subheader i18n-values="page-title:siteSettings">
124 </settings-subheader>
125 <site-settings-category
126 selected-origin="{{originSelected}}" prefs="{{prefs}}"
127 current-route="{{currentRoute}}" category="{{categorySelected}}">
128 </site-settings-category>
129 </neon-animatable>
130 <neon-animatable id="site-settings-category-images">
131 <settings-subheader i18n-values="page-title:siteSettings">
132 </settings-subheader>
133 <site-settings-category
134 selected-origin="{{originSelected}}" prefs="{{prefs}}"
135 current-route="{{currentRoute}}" category="{{categorySelected}}">
136 </site-settings-category>
137 </neon-animatable>
138 <neon-animatable id="site-settings-category-location">
139 <settings-subheader i18n-values="page-title:siteSettings">
140 </settings-subheader>
141 <site-settings-category
109 selected-origin="{{originSelected}}" prefs="{{prefs}}" 142 selected-origin="{{originSelected}}" prefs="{{prefs}}"
110 current-route="{{currentRoute}}" category="{{categorySelected}}"> 143 current-route="{{currentRoute}}" category="{{categorySelected}}">
111 </site-settings-category> 144 </site-settings-category>
112 </neon-animatable> 145 </neon-animatable>
146 <neon-animatable id="site-settings-category-javascript">
147 <settings-subheader i18n-values="page-title:siteSettings">
148 </settings-subheader>
149 <site-settings-category
150 selected-origin="{{originSelected}}" prefs="{{prefs}}"
151 current-route="{{currentRoute}}" category="{{categorySelected}}">
152 </site-settings-category>
153 </neon-animatable>
154 <neon-animatable id="site-settings-category-microphone">
155 <settings-subheader i18n-values="page-title:siteSettings">
156 </settings-subheader>
157 <site-settings-category
158 selected-origin="{{originSelected}}" prefs="{{prefs}}"
159 current-route="{{currentRoute}}" category="{{categorySelected}}">
160 </site-settings-category>
161 </neon-animatable>
162 <neon-animatable id="site-settings-category-notifications">
163 <settings-subheader i18n-values="page-title:siteSettings">
164 </settings-subheader>
165 <site-settings-category
166 selected-origin="{{originSelected}}" prefs="{{prefs}}"
167 current-route="{{currentRoute}}" category="{{categorySelected}}">
168 </site-settings-category>
169 </neon-animatable>
170 <neon-animatable id="site-settings-category-popups">
171 <settings-subheader i18n-values="page-title:siteSettings">
172 </settings-subheader>
173 <site-settings-category
174 selected-origin="{{originSelected}}" prefs="{{prefs}}"
175 current-route="{{currentRoute}}" category="{{categorySelected}}">
176 </site-settings-category>
177 </neon-animatable>
178
113 <neon-animatable id="site-details"> 179 <neon-animatable id="site-details">
114 <site-details prefs="{{prefs}}" origin="{{originSelected}}"> 180 <site-details prefs="{{prefs}}" origin="{{originSelected}}">
115 </site-details> 181 </site-details>
116 </neon-animatable> 182 </neon-animatable>
117 <neon-animatable id="clear-browsing-data"> 183 <neon-animatable id="clear-browsing-data">
118 <settings-subheader i18n-values="page-title:clearBrowsingData"> 184 <settings-subheader i18n-values="page-title:clearBrowsingData">
119 </settings-subheader> 185 </settings-subheader>
120 <settings-clear-browsing-data-page prefs="{{prefs}}"> 186 <settings-clear-browsing-data-page prefs="{{prefs}}">
121 </settings-clear-browsing-data-page> 187 </settings-clear-browsing-data-page>
122 </neon-animatable> 188 </neon-animatable>
123 </settings-animated-pages> 189 </settings-animated-pages>
124 </template> 190 </template>
125 <script src="privacy_page.js"></script> 191 <script src="privacy_page.js"></script>
126 </dom-module> 192 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698