third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp - Issue 1544673003: Refactor propagation of parsing errors for SVG attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/svg/SVGNumber.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGStaticStringList.h ('k') | third_party/WebKit/Source/core/svg/SVGString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp b/third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp

index 58531627c39a861a4d528d8dcea77fe5f122cc49..09e6b380e5f8532d987c0040a4af554113c22963 100644

--- a/third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp

@@ -97,14 +97,9 @@ SVGStringListTearOff* SVGStaticStringList::tearOff()

return m_tearOff.get();

}

-void SVGStaticStringList::setBaseValueAsString(const String& value, SVGParsingError& parseError)

+SVGParsingError SVGStaticStringList::setBaseValueAsString(const String& value)

{

- TrackExceptionState es;

- m_value->setValueAsString(value, es);

- if (es.hadException())

- parseError = ParsingAttributeFailedError;

+ return m_value->setValueAsString(value);

}