Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 } 90 }
91 91
92 SVGStringListTearOff* SVGStaticStringList::tearOff() 92 SVGStringListTearOff* SVGStaticStringList::tearOff()
93 { 93 {
94 if (!m_tearOff) 94 if (!m_tearOff)
95 m_tearOff = SVGStringListTearOff::create(m_value, contextElement(), Prop ertyIsNotAnimVal, attributeName()); 95 m_tearOff = SVGStringListTearOff::create(m_value, contextElement(), Prop ertyIsNotAnimVal, attributeName());
96 96
97 return m_tearOff.get(); 97 return m_tearOff.get();
98 } 98 }
99 99
100 void SVGStaticStringList::setBaseValueAsString(const String& value, SVGParsingEr ror& parseError) 100 SVGParsingError SVGStaticStringList::setBaseValueAsString(const String& value)
101 { 101 {
102 TrackExceptionState es; 102 return m_value->setValueAsString(value);
103
104 m_value->setValueAsString(value, es);
105
106 if (es.hadException())
107 parseError = ParsingAttributeFailedError;
108 } 103 }
109 104
110 } 105 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698