Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: third_party/WebKit/Source/core/svg/SVGString.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGString.h
diff --git a/third_party/WebKit/Source/core/svg/SVGString.h b/third_party/WebKit/Source/core/svg/SVGString.h
index d7472ff1fd6d4526b672ac45f0416917fa00217b..7388e990063eef8190962d5d24085b8fc3f80363 100644
--- a/third_party/WebKit/Source/core/svg/SVGString.h
+++ b/third_party/WebKit/Source/core/svg/SVGString.h
@@ -31,12 +31,11 @@
#ifndef SVGString_h
#define SVGString_h
+#include "core/svg/SVGParsingError.h"
#include "core/svg/properties/SVGProperty.h"
namespace blink {
-class ExceptionState;
-
class SVGString : public SVGPropertyBase {
public:
// SVGString does not have a tear-off type.
@@ -60,7 +59,11 @@ public:
}
String valueAsString() const override { return m_value; }
- void setValueAsString(const String& value, ExceptionState&) { m_value = value; }
+ SVGParsingError setValueAsString(const String& value)
+ {
+ m_value = value;
+ return NoError;
+ }
void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement*) override;

Powered by Google App Engine
This is Rietveld 408576698