third_party/WebKit/Source/core/svg/SVGStaticStringList.h - Issue 1544673003: Refactor propagation of parsing errors for SVG attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGStaticStringList.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/svg/SVGNumber.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGRect.cpp ('k') | third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGStaticStringList.h

diff --git a/third_party/WebKit/Source/core/svg/SVGStaticStringList.h b/third_party/WebKit/Source/core/svg/SVGStaticStringList.h

index 7eccaabcc6e9d69749a9ce70704eceae0f0993c6..d71ad55aabc5499d0e745a3d0a016347373acce2 100644

--- a/third_party/WebKit/Source/core/svg/SVGStaticStringList.h

+++ b/third_party/WebKit/Source/core/svg/SVGStaticStringList.h

@@ -59,7 +59,7 @@ public:

void animationEnded() override;

bool needsSynchronizeAttribute() override;

- void setBaseValueAsString(const String& value, SVGParsingError& parseError);

+ SVGParsingError setBaseValueAsString(const String&);

SVGStringList* value() { return m_value.get(); }

SVGStringListTearOff* tearOff();