Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544333002: Convert Pass()→std::move() in //tools (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //tools ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=brettw@chromium.org,rdevlin.cronin@chromium.org Committed: https://crrev.com/424dfa526b76b06bb364a773fbaa6d19fb36d0ce Cr-Commit-Position: refs/heads/master@{#366943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -114 lines) Patch
M tools/gn/build_settings.h View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gn/build_settings.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/gn/builder.cc View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gn/builder_record.h View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gn/function_toolchain.cc View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gn/functions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/functions_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/gn/input_conversion.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/gn/input_file_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/gn/loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M tools/gn/operators_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M tools/gn/parse_tree.h View 8 chunks +13 lines, -23 lines 0 comments Download
M tools/gn/parse_tree_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/gn/parser.cc View 19 chunks +35 lines, -33 lines 0 comments Download
M tools/gn/scope.h View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gn/scope.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/setup.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/string_utils_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/gn/target_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/gn/template.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/test_with_scope.cc View 9 chunks +13 lines, -10 lines 0 comments Download
M tools/gn/toolchain.cc View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gn/value.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/test/simple_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/test_util.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
+avi for general review / sanity check +brettw for //tools/gn owners review +rdevlin.cronin for //tools/json_schema_compiler ...
4 years, 12 months ago (2015-12-27 22:06:07 UTC) #1
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-27 22:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544333002/1
4 years, 12 months ago (2015-12-27 22:33:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-27 23:15:57 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/424dfa526b76b06bb364a773fbaa6d19fb36d0ce Cr-Commit-Position: refs/heads/master@{#366943}
4 years, 12 months ago (2015-12-27 23:17:24 UTC) #7
Devlin
json_schema_compiler lgtm
4 years, 12 months ago (2015-12-28 17:18:29 UTC) #8
brettw
4 years, 11 months ago (2015-12-29 22:18:33 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698