Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/gn/string_utils_unittest.cc

Issue 1544333002: Convert Pass()→std::move() in //tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/setup.cc ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/string_utils_unittest.cc
diff --git a/tools/gn/string_utils_unittest.cc b/tools/gn/string_utils_unittest.cc
index a00e8249d5403f2f2501882c282899b2bd4ded3a..4e18eb5c78c7ad92fb4004cfd59978d5434bc160 100644
--- a/tools/gn/string_utils_unittest.cc
+++ b/tools/gn/string_utils_unittest.cc
@@ -2,13 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "tools/gn/string_utils.h"
+
#include <stdint.h>
+#include <utility>
#include "testing/gtest/include/gtest/gtest.h"
#include "tools/gn/err.h"
#include "tools/gn/scope.h"
#include "tools/gn/settings.h"
-#include "tools/gn/string_utils.h"
#include "tools/gn/token.h"
#include "tools/gn/value.h"
@@ -23,7 +25,7 @@ bool CheckExpansionCase(const char* input, const char* expected, bool success) {
// Nested scope called "onescope" with a value "one" inside it.
scoped_ptr<Scope> onescope(new Scope(static_cast<const Settings*>(nullptr)));
onescope->SetValue("one", Value(nullptr, one), nullptr);
- scope.SetValue("onescope", Value(nullptr, onescope.Pass()), nullptr);
+ scope.SetValue("onescope", Value(nullptr, std::move(onescope)), nullptr);
// List called "onelist" with one value that maps to 1.
Value onelist(nullptr, Value::LIST);
« no previous file with comments | « tools/gn/setup.cc ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698