tools/gn/scope.cc - Issue 1544333002: Convert Pass()→std::move() in //tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/scope.cc

Issue 1544333002: Convert Pass()→std::move() in //tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/scope.cc

diff --git a/tools/gn/scope.cc b/tools/gn/scope.cc

index 37ddbddb11a35fb08d32edb8a036c8f4cfe87dd3..2bf9dd467da7903b5ff4a874915d5f1481429fea 100644

--- a/tools/gn/scope.cc

+++ b/tools/gn/scope.cc

@@ -377,7 +377,7 @@ scoped_ptr<Scope> Scope::MakeClosure() const {

NonRecursiveMergeTo(result.get(), options, nullptr, "<SHOULDN'T HAPPEN>",

&err);

DCHECK(!err.has_error());

- return result.Pass();

+ return result;

}

Scope* Scope::MakeTargetDefaults(const std::string& target_type) {

« no previous file with comments | « tools/gn/scope.h ('k') | tools/gn/setup.cc » ('j') | no next file with comments »