Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/function_toolchain.cc

Issue 1544333002: Convert Pass()→std::move() in //tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/builder_record.h ('k') | tools/gn/functions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index ed4bbc37d96105428eb47585422fbb078c075382..58532551d4f2d65250db6002fbaf675eec20cff7 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -4,6 +4,7 @@
#include <algorithm>
#include <limits>
+#include <utility>
#include "tools/gn/err.h"
#include "tools/gn/functions.h"
@@ -892,7 +893,7 @@ Value RunTool(Scope* scope,
if (!block_scope.CheckForUnusedVars(err))
return Value();
- toolchain->SetTool(tool_type, tool.Pass());
+ toolchain->SetTool(tool_type, std::move(tool));
return Value();
}
« no previous file with comments | « tools/gn/builder_record.h ('k') | tools/gn/functions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698