Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1542093002: [turbofan] Exhaustive switches for MachineRepresentation. (Closed)

Created:
5 years ago by Jarin
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Exhaustive switches for MachineRepresentation. Committed: https://crrev.com/739c018735db0c6750ced519ac820e8579630195 Cr-Commit-Position: refs/heads/master@{#33011}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Win compiler happy? #

Patch Set 4 : GCC happy? #

Patch Set 5 : Another attempt to soothe gcc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -70 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 2 3 4 8 chunks +16 lines, -8 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 3 4 8 chunks +12 lines, -8 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 4 8 chunks +16 lines, -8 lines 0 comments Download
M src/compiler/instruction.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
M src/compiler/instruction.cc View 3 chunks +13 lines, -4 lines 0 comments Download
M src/compiler/machine-operator.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 4 7 chunks +12 lines, -7 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 3 4 8 chunks +12 lines, -8 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/register-allocator.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 4 8 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
5 years ago (2015-12-22 12:57:18 UTC) #2
Benedikt Meurer
lgtm
5 years ago (2015-12-22 13:52:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542093002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542093002/80001
5 years ago (2015-12-22 13:52:55 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-22 13:54:10 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-22 13:54:45 UTC) #8
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/739c018735db0c6750ced519ac820e8579630195
Cr-Commit-Position: refs/heads/master@{#33011}

Powered by Google App Engine
This is Rietveld 408576698