src/compiler/machine-operator.cc - Issue 1542093002: [turbofan] Exhaustive switches for MachineRepresentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/machine-operator.cc

Issue 1542093002: [turbofan] Exhaustive switches for MachineRepresentation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Another attempt to soothe gcc Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/machine-operator.cc

diff --git a/src/compiler/machine-operator.cc b/src/compiler/machine-operator.cc

index 10f33070a1fc38839e2ab77967c1365f83299421..4540d035bbbc7ef77a09ffefeeadcc3b6876bbf7 100644

--- a/src/compiler/machine-operator.cc

+++ b/src/compiler/machine-operator.cc

@@ -394,7 +394,8 @@ const Operator* MachineOperatorBuilder::Store(StoreRepresentation store_rep) {

break;

MACHINE_REPRESENTATION_LIST(STORE)

#undef STORE

- default:

+ case MachineRepresentation::kBit:

+ case MachineRepresentation::kNone:

break;

}

UNREACHABLE();

@@ -423,7 +424,8 @@ const Operator* MachineOperatorBuilder::CheckedStore(

return &cache_.kCheckedStore##kRep;

MACHINE_REPRESENTATION_LIST(STORE)

#undef STORE

- default:

+ case MachineRepresentation::kBit:

+ case MachineRepresentation::kNone:

break;

}

UNREACHABLE();

« no previous file with comments | « src/compiler/instruction.cc ('k') | src/compiler/mips/instruction-selector-mips.cc » ('j') | no next file with comments »