src/compiler/ppc/instruction-selector-ppc.cc - Issue 1542093002: [turbofan] Exhaustive switches for MachineRepresentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ppc/instruction-selector-ppc.cc

Issue 1542093002: [turbofan] Exhaustive switches for MachineRepresentation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Another attempt to soothe gcc Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ppc/instruction-selector-ppc.cc

diff --git a/src/compiler/ppc/instruction-selector-ppc.cc b/src/compiler/ppc/instruction-selector-ppc.cc

index bf0e1ba6a043766287df0db1ea617bedd072422f..82fc98d7bc657b150528364977cb433d54b291c5 100644

--- a/src/compiler/ppc/instruction-selector-ppc.cc

+++ b/src/compiler/ppc/instruction-selector-ppc.cc

@@ -198,7 +198,10 @@ void InstructionSelector::VisitLoad(Node* node) {

mode = kInt16Imm_4ByteAligned;

break;

#endif

- default:

+#if !V8_TARGET_ARCH_PPC64

+ case MachineRepresentation::kWord64:

+#endif

+ case MachineRepresentation::kNone:

UNREACHABLE();

return;

}