Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: src/compiler/instruction.cc

Issue 1542093002: [turbofan] Exhaustive switches for MachineRepresentation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Another attempt to soothe gcc Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction.h ('k') | src/compiler/machine-operator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.cc
diff --git a/src/compiler/instruction.cc b/src/compiler/instruction.cc
index e3d4901bdd58969a25f425cbbc99502548c6feac..bd090b1c2115efb9d4d822fe4240f324840dbe16 100644
--- a/src/compiler/instruction.cc
+++ b/src/compiler/instruction.cc
@@ -139,6 +139,18 @@ std::ostream& operator<<(std::ostream& os,
os << "|E";
}
switch (allocated.representation()) {
+ case MachineRepresentation::kNone:
+ os << "|-";
+ break;
+ case MachineRepresentation::kBit:
+ os << "|b";
+ break;
+ case MachineRepresentation::kWord8:
+ os << "|w8";
+ break;
+ case MachineRepresentation::kWord16:
+ os << "|w16";
+ break;
case MachineRepresentation::kWord32:
os << "|w32";
break;
@@ -154,9 +166,6 @@ std::ostream& operator<<(std::ostream& os,
case MachineRepresentation::kTagged:
os << "|t";
break;
- default:
- os << "|?";
- break;
}
return os << "]";
}
@@ -718,7 +727,7 @@ static MachineRepresentation FilterRepresentation(MachineRepresentation rep) {
case MachineRepresentation::kFloat64:
case MachineRepresentation::kTagged:
return rep;
- default:
+ case MachineRepresentation::kNone:
break;
}
UNREACHABLE();
« no previous file with comments | « src/compiler/instruction.h ('k') | src/compiler/machine-operator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698