Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1540263004: Reland of [es6] ship regexp sticky flag. (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
Yang, Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [es6] ship regexp sticky flag. (patchset #1 id:1 of https://codereview.chromium.org/1531043002/ ) Reason for revert: This can be relanded since the web compatibility fix in https://codereview.chromium.org/1543723002 has been submitted. Original issue's description: > Revert of [es6] ship regexp sticky flag. (patchset #2 id:20001 of https://codereview.chromium.org/1509733010/ ) > > Reason for revert: > This causes compatibility issues, as documented in https://bugs.chromium.org/p/v8/issues/detail?id=4617#c9 > > Original issue's description: > > [es6] ship regexp sticky flag. > > > > R=littledan@chromium.org > > BUG=v8:4342 > > LOG=Y > > > > Committed: https://crrev.com/86c2dd4042dc9ce293e004234eb094f2b51d9640 > > Cr-Commit-Position: refs/heads/master@{#32826} > > TBR=yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4342 TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/flag-definitions.h View 1 chunk +8 lines, -8 lines 0 comments Download
M test/mjsunit/regexp-not-sticky-yet.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Dan Ehrenberg
Created Reland of [es6] ship regexp sticky flag.
5 years ago (2015-12-22 06:38:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540263004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540263004/1
5 years ago (2015-12-22 06:38:13 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/flag-definitions.h: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-12-22 06:38:58 UTC) #4
Yang
On 2015/12/22 06:38:58, commit-bot: I haz the power wrote: > Failed to apply patch for ...
5 years ago (2015-12-22 08:21:46 UTC) #5
Michael Hablich
https://codereview.chromium.org/1543723002 just got reverted => not lgtm
5 years ago (2015-12-22 08:25:13 UTC) #6
Dan Ehrenberg
On 2015/12/22 at 08:25:13, hablich wrote: > https://codereview.chromium.org/1543723002 just got reverted => not lgtm I ...
5 years ago (2015-12-22 08:28:49 UTC) #7
Dan Ehrenberg
5 years ago (2015-12-22 08:53:46 UTC) #8
Message was sent while issue was closed.
On 2015/12/22 at 08:28:49, Dan Ehrenberg wrote:
> On 2015/12/22 at 08:25:13, hablich wrote:
> > https://codereview.chromium.org/1543723002 just got reverted => not lgtm
> 
> I think we can go ahead with this patch once
https://codereview.chromium.org/1545633002 goes through. Or do you think
otherwise, hablich@?

This has a merge conflict and is subsumed by
https://codereview.chromium.org/1546563002

Powered by Google App Engine
This is Rietveld 408576698