Add web compat workarounds for ES2015 RegExp semantics

Add web compat workarounds for ES2015 RegExp semantics

Unexpectedly, websites depend on doing feature testing with
RegExp.prototype.sticky and browser testing with RegExp.prototype.toString().
ES2015 newly throws exceptions for both of these. In order to enable shipping
new ES2015 semantics, this patch puts in narrow workarounds for those two
cases, keeping their old behavior. UseCounters are added for how often
those particular cases come up, so we can see if it can be deprecated.

R=yangguo
BUG=v8:4637, v8:4617
LOG=Y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/98f819c3e0c92d54a306cdacadda73cf96d21b52
Cr-Commit-Position: refs/heads/master@{#32997}

[Dan Ehrenberg, 2015-12-21 23:32:02]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-21 23:32:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543723002/1

[commit-bot: I haz the power, 2015-12-21 23:34:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 23:34:14]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9189)

[Dan Ehrenberg, 2015-12-21 23:40:55]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-21 23:41:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543723002/20001

[commit-bot: I haz the power, 2015-12-21 23:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 23:53:38]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13476)

[Dan Ehrenberg, 2015-12-22 00:24:19]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-22 00:24:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543723002/40001

[Dan Ehrenberg, 2015-12-22 00:25:36]

Description was changed from

==========
Add web compat workarounds for ES2015 RegExp semantics

Unexpectedly, websites depend on doing feature testing with
RegExp.prototype.sticky and browser testing with RegExp.prototype.toString().
ES2015 newly throws exceptions for both of these. In order to enable shipping
new ES2015 semantics, this patch puts in narrow workarounds for those two
cases, keeping their old behavior. UseCounters are added for how often
those particular cases come up, so we can see if it can be deprecated.

R=yangguo
BUG=v8:4637,v8:4617
LOG=Y
==========

to

==========
Add web compat workarounds for ES2015 RegExp semantics

Unexpectedly, websites depend on doing feature testing with
RegExp.prototype.sticky and browser testing with RegExp.prototype.toString().
ES2015 newly throws exceptions for both of these. In order to enable shipping
new ES2015 semantics, this patch puts in narrow workarounds for those two
cases, keeping their old behavior. UseCounters are added for how often
those particular cases come up, so we can see if it can be deprecated.

R=yangguo
BUG=v8:4637,v8:4617
LOG=Y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2015-12-22 05:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-22 05:04:03]

Dry run: This issue passed the CQ dry run.

[Yang, 2015-12-22 06:31:21]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2015-12-22 06:31:22]

lgtm. thanks.

https://codereview.chromium.org/1543723002/diff/40001/src/js/regexp.js
File src/js/regexp.js (right):

https://codereview.chromium.org/1543723002/diff/40001/src/js/regexp.js#newcod...
src/js/regexp.js:503: const GlobalRegExpPrototype = new GlobalObject();
Regexp.js is one of the remaining native scripts that are not in strict mode.
Not sure whether we want legacy const here.

[Dan Ehrenberg, 2015-12-22 06:33:48]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2015-12-22 06:33:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543723002/40001

[commit-bot: I haz the power, 2015-12-22 06:35:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-22 06:36:23]

Description was changed from

==========
Add web compat workarounds for ES2015 RegExp semantics

Unexpectedly, websites depend on doing feature testing with
RegExp.prototype.sticky and browser testing with RegExp.prototype.toString().
ES2015 newly throws exceptions for both of these. In order to enable shipping
new ES2015 semantics, this patch puts in narrow workarounds for those two
cases, keeping their old behavior. UseCounters are added for how often
those particular cases come up, so we can see if it can be deprecated.

R=yangguo
BUG=v8:4637,v8:4617
LOG=Y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
Add web compat workarounds for ES2015 RegExp semantics

Unexpectedly, websites depend on doing feature testing with
RegExp.prototype.sticky and browser testing with RegExp.prototype.toString().
ES2015 newly throws exceptions for both of these. In order to enable shipping
new ES2015 semantics, this patch puts in narrow workarounds for those two
cases, keeping their old behavior. UseCounters are added for how often
those particular cases come up, so we can see if it can be deprecated.

R=yangguo
BUG=v8:4637,v8:4617
LOG=Y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/98f819c3e0c92d54a306cdacadda73cf96d21b52
Cr-Commit-Position: refs/heads/master@{#32997}
==========

[commit-bot: I haz the power, 2015-12-22 06:36:24]

Patchset 3 (id:??) landed as
https://crrev.com/98f819c3e0c92d54a306cdacadda73cf96d21b52
Cr-Commit-Position: refs/heads/master@{#32997}

[Dan Ehrenberg, 2015-12-22 07:20:42]

https://codereview.chromium.org/1543723002/diff/40001/src/js/regexp.js
File src/js/regexp.js (right):

https://codereview.chromium.org/1543723002/diff/40001/src/js/regexp.js#newcod...
src/js/regexp.js:503: const GlobalRegExpPrototype = new GlobalObject();
On 2015/12/22 at 06:31:22, Yang wrote:
> Regexp.js is one of the remaining native scripts that are not in strict mode.
Not sure whether we want legacy const here.

I think this makes sense, since it'll be a clean upgrade to ES2015 const
semantics.

[Benedikt Meurer, 2015-12-22 07:36:54]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1546493003/ by bmeurer@chromium.org.

The reason for reverting is: Breaks nosnap:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds....