Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1546563002: Reland of [es6] ship regexp sticky flag. (patchset #1 id:1 of https://codereview.chromium.org/15310… (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
Yang, Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [es6] ship regexp sticky flag. (patchset #1 id:1 of https://codereview.chromium.org/1531043002/ ) Reason for revert: This can be relanded since the web compatibility fix in https://codereview.chromium.org/1543723002 has been submitted. Original issue's description: > Revert of [es6] ship regexp sticky flag. (patchset #2 id:20001 of https://codereview.chromium.org/1509733010/ ) > > Reason for revert: > This causes compatibility issues, as documented in https://bugs.chromium.org/p/v8/issues/detail?id=4617#c9 > > Original issue's description: > > [es6] ship regexp sticky flag. > > > > R=littledan@chromium.org > > BUG=v8:4342 > > LOG=Y > > > > Committed: https://crrev.com/86c2dd4042dc9ce293e004234eb094f2b51d9640 > > Cr-Commit-Position: refs/heads/master@{#32826} > > TBR=yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4342 TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4342 Committed: https://crrev.com/155cbad50a811f0e2256074b0093a6457e95b7d5 Cr-Commit-Position: refs/heads/master@{#33003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dan Ehrenberg
5 years ago (2015-12-22 08:53:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546563002/1
5 years ago (2015-12-22 08:53:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-22 08:53:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546563002/1
5 years ago (2015-12-22 09:20:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 09:20:39 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/155cbad50a811f0e2256074b0093a6457e95b7d5 Cr-Commit-Position: refs/heads/master@{#33003}
5 years ago (2015-12-22 09:21:26 UTC) #11
Michael Hablich
5 years ago (2015-12-22 09:21:36 UTC) #12
Message was sent while issue was closed.
On 2015/12/22 08:53:28, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

lgtm. Btw reland of fix is https://codereview.chromium.org/1545633002

Powered by Google App Engine
This is Rietveld 408576698