Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1545633002: Reland of Add web compat workarounds for ES2015 RegExp semantics (patchset #3 id:40001 of https://c… (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
yangguo, Yang
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Add web compat workarounds for ES2015 RegExp semantics (patchset #3 id:40001 of https://codereview.chromium.org/1543723002/ ) Unexpectedly, websites depend on doing feature testing with RegExp.prototype.sticky and browser testing with RegExp.prototype.toString(). ES2015 newly throws exceptions for both of these. In order to enable shipping new ES2015 semantics, this patch puts in narrow workarounds for those two cases, keeping their old behavior. UseCounters are added for how often those particular cases come up, so we can see if it can be deprecated. This reland replaces problematic legacy const usage with var, to avoid issues with nosnap builds. R=yangguo CC=bmeurer BUG=v8:4637, v8:4617 LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/424ef009a5d394ca212de8b8c91b963e424f7e72 Cr-Commit-Position: refs/heads/master@{#33002}

Patch Set 1 #

Patch Set 2 : Move var declaration up to fix debug build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -5 lines) Patch
M include/v8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/harmony-regexp.js View 2 chunks +8 lines, -0 lines 0 comments Download
M src/js/regexp.js View 1 3 chunks +12 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 2 chunks +80 lines, -0 lines 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 chunk +5 lines, -1 line 0 comments Download
M test/webkit/fast/js/kde/RegExp-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Dan Ehrenberg
5 years ago (2015-12-22 08:03:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545633002/1
5 years ago (2015-12-22 08:03:22 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/13364) v8_linux_arm_rel on ...
5 years ago (2015-12-22 08:06:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545633002/20001
5 years ago (2015-12-22 08:20:24 UTC) #7
Yang
lgtm
5 years ago (2015-12-22 08:22:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545633002/20001
5 years ago (2015-12-22 08:37:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-22 09:16:33 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-22 09:17:02 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/424ef009a5d394ca212de8b8c91b963e424f7e72
Cr-Commit-Position: refs/heads/master@{#33002}

Powered by Google App Engine
This is Rietveld 408576698