Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1539863002: Convert Pass()→std::move() in mojo/services/ (Closed)

Created:
5 years ago by dcheng
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //mojo/services BUG=557422 R=avi@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/db55f3863d6f94edb16bd3e8060338a2bb293da9 Cr-Commit-Position: refs/heads/master@{#366165}

Patch Set 1 #

Patch Set 2 : Fix missing forward declare that was masked by pre-existing incorrect #include ordering. #

Patch Set 3 : Fix missing forward declare that was masked by pre-existing incorrect #include ordering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -253 lines) Patch
M mojo/services/network/cookie_store_impl.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/network/http_connection_impl.cc View 10 chunks +18 lines, -17 lines 0 comments Download
M mojo/services/network/http_server_apptest.cc View 18 chunks +31 lines, -26 lines 0 comments Download
M mojo/services/network/http_server_impl.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M mojo/services/network/net_adapters.cc View 8 chunks +9 lines, -11 lines 0 comments Download
M mojo/services/network/net_address_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_context.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 7 chunks +13 lines, -12 lines 0 comments Download
M mojo/services/network/network_service_impl.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M mojo/services/network/public/cpp/udp_socket_wrapper.cc View 14 chunks +23 lines, -23 lines 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M mojo/services/network/tcp_server_socket_impl.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 14 chunks +24 lines, -22 lines 0 comments Download
M mojo/services/network/udp_socket_impl.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M mojo/services/network/url_loader_factory_impl.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/services/network/url_loader_impl.cc View 9 chunks +14 lines, -13 lines 0 comments Download
M mojo/services/network/url_loader_impl_apptest.cc View 7 chunks +8 lines, -6 lines 0 comments Download
M mojo/services/network/web_socket_factory_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/services/network/web_socket_impl.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_impl.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M mojo/services/test_service/test_service_application.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_service_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M mojo/services/test_service/tracked_service.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/services/tracing/public/cpp/trace_provider_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/services/tracing/trace_data_sink.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/services/tracing/trace_recorder_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/services/tracing/tracing_app.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
dcheng
5 years ago (2015-12-18 09:15:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539863002/1
5 years ago (2015-12-18 09:16:25 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/158220)
5 years ago (2015-12-18 09:31:34 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539863002/40001
5 years ago (2015-12-18 09:38:11 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 10:12:32 UTC) #11
Avi (use Gerrit)
stampity stamp lgtm
5 years ago (2015-12-18 20:58:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539863002/40001
5 years ago (2015-12-18 20:59:11 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-18 21:05:44 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-18 21:07:24 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/db55f3863d6f94edb16bd3e8060338a2bb293da9
Cr-Commit-Position: refs/heads/master@{#366165}

Powered by Google App Engine
This is Rietveld 408576698