Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: mojo/services/network/net_adapters.cc

Issue 1539863002: Convert Pass()→std::move() in mojo/services/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix missing forward declare that was masked by pre-existing incorrect #include ordering. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/network/net_adapters.h" 5 #include "mojo/services/network/net_adapters.h"
6 6
7 #include <utility>
8
7 #include "net/base/net_errors.h" 9 #include "net/base/net_errors.h"
8 10
9 namespace mojo { 11 namespace mojo {
10 12
11 namespace { 13 namespace {
12 14
13 const uint32_t kMaxBufSize = 64 * 1024; 15 const uint32_t kMaxBufSize = 64 * 1024;
14 16
15 } // namespace 17 } // namespace
16 18
17 NetToMojoPendingBuffer::NetToMojoPendingBuffer( 19 NetToMojoPendingBuffer::NetToMojoPendingBuffer(
18 ScopedDataPipeProducerHandle handle, 20 ScopedDataPipeProducerHandle handle,
19 void* buffer) 21 void* buffer)
20 : handle_(handle.Pass()), 22 : handle_(std::move(handle)), buffer_(buffer) {}
21 buffer_(buffer) {
22 }
23 23
24 NetToMojoPendingBuffer::~NetToMojoPendingBuffer() { 24 NetToMojoPendingBuffer::~NetToMojoPendingBuffer() {
25 if (handle_.is_valid()) 25 if (handle_.is_valid())
26 EndWriteDataRaw(handle_.get(), 0); 26 EndWriteDataRaw(handle_.get(), 0);
27 } 27 }
28 28
29 // static 29 // static
30 MojoResult NetToMojoPendingBuffer::BeginWrite( 30 MojoResult NetToMojoPendingBuffer::BeginWrite(
31 ScopedDataPipeProducerHandle* handle, 31 ScopedDataPipeProducerHandle* handle,
32 scoped_refptr<NetToMojoPendingBuffer>* pending, 32 scoped_refptr<NetToMojoPendingBuffer>* pending,
33 uint32_t* num_bytes) { 33 uint32_t* num_bytes) {
34 void* buf; 34 void* buf;
35 *num_bytes = 0; 35 *num_bytes = 0;
36 36
37 MojoResult result = BeginWriteDataRaw(handle->get(), &buf, num_bytes, 37 MojoResult result = BeginWriteDataRaw(handle->get(), &buf, num_bytes,
38 MOJO_WRITE_DATA_FLAG_NONE); 38 MOJO_WRITE_DATA_FLAG_NONE);
39 if (result == MOJO_RESULT_OK) { 39 if (result == MOJO_RESULT_OK) {
40 if (*num_bytes > kMaxBufSize) 40 if (*num_bytes > kMaxBufSize)
41 *num_bytes = kMaxBufSize; 41 *num_bytes = kMaxBufSize;
42 *pending = new NetToMojoPendingBuffer(handle->Pass(), buf); 42 *pending = new NetToMojoPendingBuffer(std::move(*handle), buf);
43 } 43 }
44 return result; 44 return result;
45 } 45 }
46 46
47 ScopedDataPipeProducerHandle NetToMojoPendingBuffer::Complete( 47 ScopedDataPipeProducerHandle NetToMojoPendingBuffer::Complete(
48 uint32_t num_bytes) { 48 uint32_t num_bytes) {
49 EndWriteDataRaw(handle_.get(), num_bytes); 49 EndWriteDataRaw(handle_.get(), num_bytes);
50 buffer_ = NULL; 50 buffer_ = NULL;
51 return handle_.Pass(); 51 return std::move(handle_);
52 } 52 }
53 53
54 // ----------------------------------------------------------------------------- 54 // -----------------------------------------------------------------------------
55 55
56 NetToMojoIOBuffer::NetToMojoIOBuffer( 56 NetToMojoIOBuffer::NetToMojoIOBuffer(
57 NetToMojoPendingBuffer* pending_buffer) 57 NetToMojoPendingBuffer* pending_buffer)
58 : net::WrappedIOBuffer(pending_buffer->buffer()), 58 : net::WrappedIOBuffer(pending_buffer->buffer()),
59 pending_buffer_(pending_buffer) { 59 pending_buffer_(pending_buffer) {
60 } 60 }
61 61
62 NetToMojoIOBuffer::~NetToMojoIOBuffer() { 62 NetToMojoIOBuffer::~NetToMojoIOBuffer() {
63 } 63 }
64 64
65 // ----------------------------------------------------------------------------- 65 // -----------------------------------------------------------------------------
66 66
67 MojoToNetPendingBuffer::MojoToNetPendingBuffer( 67 MojoToNetPendingBuffer::MojoToNetPendingBuffer(
68 ScopedDataPipeConsumerHandle handle, 68 ScopedDataPipeConsumerHandle handle,
69 const void* buffer) 69 const void* buffer)
70 : handle_(handle.Pass()), 70 : handle_(std::move(handle)), buffer_(buffer) {}
71 buffer_(buffer) {
72 }
73 71
74 MojoToNetPendingBuffer::~MojoToNetPendingBuffer() { 72 MojoToNetPendingBuffer::~MojoToNetPendingBuffer() {
75 } 73 }
76 74
77 // static 75 // static
78 MojoResult MojoToNetPendingBuffer::BeginRead( 76 MojoResult MojoToNetPendingBuffer::BeginRead(
79 ScopedDataPipeConsumerHandle* handle, 77 ScopedDataPipeConsumerHandle* handle,
80 scoped_refptr<MojoToNetPendingBuffer>* pending, 78 scoped_refptr<MojoToNetPendingBuffer>* pending,
81 uint32_t* num_bytes) { 79 uint32_t* num_bytes) {
82 const void* buffer = NULL; 80 const void* buffer = NULL;
83 *num_bytes = 0; 81 *num_bytes = 0;
84 MojoResult result = BeginReadDataRaw(handle->get(), &buffer, num_bytes, 82 MojoResult result = BeginReadDataRaw(handle->get(), &buffer, num_bytes,
85 MOJO_READ_DATA_FLAG_NONE); 83 MOJO_READ_DATA_FLAG_NONE);
86 if (result == MOJO_RESULT_OK) 84 if (result == MOJO_RESULT_OK)
87 *pending = new MojoToNetPendingBuffer(handle->Pass(), buffer); 85 *pending = new MojoToNetPendingBuffer(std::move(*handle), buffer);
88 return result; 86 return result;
89 } 87 }
90 88
91 ScopedDataPipeConsumerHandle MojoToNetPendingBuffer::Complete( 89 ScopedDataPipeConsumerHandle MojoToNetPendingBuffer::Complete(
92 uint32_t num_bytes) { 90 uint32_t num_bytes) {
93 EndReadDataRaw(handle_.get(), num_bytes); 91 EndReadDataRaw(handle_.get(), num_bytes);
94 buffer_ = NULL; 92 buffer_ = NULL;
95 return handle_.Pass(); 93 return std::move(handle_);
96 } 94 }
97 95
98 // ----------------------------------------------------------------------------- 96 // -----------------------------------------------------------------------------
99 97
100 MojoToNetIOBuffer::MojoToNetIOBuffer(MojoToNetPendingBuffer* pending_buffer) 98 MojoToNetIOBuffer::MojoToNetIOBuffer(MojoToNetPendingBuffer* pending_buffer)
101 : net::WrappedIOBuffer(pending_buffer->buffer()), 99 : net::WrappedIOBuffer(pending_buffer->buffer()),
102 pending_buffer_(pending_buffer) { 100 pending_buffer_(pending_buffer) {
103 } 101 }
104 102
105 MojoToNetIOBuffer::~MojoToNetIOBuffer() { 103 MojoToNetIOBuffer::~MojoToNetIOBuffer() {
106 } 104 }
107 105
108 // ----------------------------------------------------------------------------- 106 // -----------------------------------------------------------------------------
109 107
110 NetworkErrorPtr MakeNetworkError(int error_code) { 108 NetworkErrorPtr MakeNetworkError(int error_code) {
111 NetworkErrorPtr error = NetworkError::New(); 109 NetworkErrorPtr error = NetworkError::New();
112 error->code = error_code; 110 error->code = error_code;
113 if (error_code <= 0) 111 if (error_code <= 0)
114 error->description = net::ErrorToString(error_code); 112 error->description = net::ErrorToString(error_code);
115 return error.Pass(); 113 return error;
116 } 114 }
117 115
118 } // namespace mojo 116 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/services/network/http_server_impl.cc ('k') | mojo/services/network/net_address_type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698