mojo/services/tracing/trace_data_sink.cc - Issue 1539863002: Convert Pass()→std::move() in mojo/services/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/tracing/trace_data_sink.cc

Issue 1539863002: Convert Pass()→std::move() in mojo/services/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix missing forward declare that was masked by pre-existing incorrect #include ordering. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/tracing/trace_data_sink.cc

diff --git a/mojo/services/tracing/trace_data_sink.cc b/mojo/services/tracing/trace_data_sink.cc

index 1174bfc06cc18176830bef7514d6ff9c1d81d573..e608a7452d623830bdcab8902a82e36224c374e5 100644

--- a/mojo/services/tracing/trace_data_sink.cc

+++ b/mojo/services/tracing/trace_data_sink.cc

@@ -4,6 +4,8 @@

#include "mojo/services/tracing/trace_data_sink.h"

+#include <utility>

#include "base/logging.h"

#include "mojo/common/data_pipe_utils.h"

@@ -12,8 +14,7 @@ using mojo::common::BlockingCopyFromString;

namespace tracing {

TraceDataSink::TraceDataSink(mojo::ScopedDataPipeProducerHandle pipe)

- : pipe_(pipe.Pass()), empty_(true) {

+ : pipe_(std::move(pipe)), empty_(true) {}

TraceDataSink::~TraceDataSink() {

if (pipe_.is_valid())