Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: mojo/services/test_service/test_request_tracker_impl.cc

Issue 1539863002: Convert Pass()→std::move() in mojo/services/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix missing forward declare that was masked by pre-existing incorrect #include ordering. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/test_service/test_request_tracker_impl.cc
diff --git a/mojo/services/test_service/test_request_tracker_impl.cc b/mojo/services/test_service/test_request_tracker_impl.cc
index 09fa4d5fad75600aef4ab9be36773b69c9ee8c32..8e2dab4d55c6a065bb16b6013a1517a700e6eb63 100644
--- a/mojo/services/test_service/test_request_tracker_impl.cc
+++ b/mojo/services/test_service/test_request_tracker_impl.cc
@@ -4,6 +4,8 @@
#include "mojo/services/test_service/test_request_tracker_impl.h"
+#include <utility>
+
namespace mojo {
namespace test {
@@ -16,8 +18,9 @@ TrackingContext::~TrackingContext() {
TestRequestTrackerImpl::TestRequestTrackerImpl(
InterfaceRequest<TestRequestTracker> request,
TrackingContext* context)
- : context_(context), binding_(this, request.Pass()), weak_factory_(this) {
-}
+ : context_(context),
+ binding_(this, std::move(request)),
+ weak_factory_(this) {}
TestRequestTrackerImpl::~TestRequestTrackerImpl() {
}
@@ -42,8 +45,7 @@ void TestRequestTrackerImpl::SetNameAndReturnId(
TestTrackedRequestServiceImpl::TestTrackedRequestServiceImpl(
InterfaceRequest<TestTrackedRequestService> request,
TrackingContext* context)
- : context_(context), binding_(this, request.Pass()) {
-}
+ : context_(context), binding_(this, std::move(request)) {}
TestTrackedRequestServiceImpl::~TestTrackedRequestServiceImpl() {
}
@@ -66,9 +68,9 @@ void TestTrackedRequestServiceImpl::GetReport(
mean_health_numerator += it2->health;
}
report->mean_health = mean_health_numerator / num_samples;
- reports.push_back(report.Pass());
+ reports.push_back(std::move(report));
}
- callback.Run(reports.Pass());
+ callback.Run(std::move(reports));
}
} // namespace test
« no previous file with comments | « mojo/services/test_service/test_request_tracker_application.cc ('k') | mojo/services/test_service/test_service_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698