Add default ctor to SkMask

Add default ctor to SkMask

The minimal fix here seems to be handling BoxBlur's return value in SkBlurMaskFilter.cpp::GrRRectBlurEffect::Create. We seem to do enough special handling of the fImage field though that always initialializing it may not be a bad idea.

BUG=570232
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1539553002

Committed: https://skia.googlesource.com/skia/+/e80eb928ba0248a5a5dea6e1f0005aa08ecf8740

[robertphillips, 2015-12-17 16:52:24]

Description was changed from

==========
Add default ctor to SkMask

BUG=570232
==========

to

==========
Add default ctor to SkMask

BUG=570232
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2015-12-17 16:54:22]

Description was changed from

==========
Add default ctor to SkMask

BUG=570232
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add default ctor to SkMask

The minimal fix here seems to be handling BoxBlur's return value in
SkBlurMaskFilter.cpp::GrRRectBlurEffect::Create. We seem to do enough special
handling of the fImage field that always initialializing it may not be a bad
idea.

BUG=570232
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2015-12-17 16:54:22]

robertphillips@google.com changed reviewers:
+ reed@google.com

[robertphillips, 2015-12-17 16:54:48]

Description was changed from

==========
Add default ctor to SkMask

The minimal fix here seems to be handling BoxBlur's return value in
SkBlurMaskFilter.cpp::GrRRectBlurEffect::Create. We seem to do enough special
handling of the fImage field that always initialializing it may not be a bad
idea.

BUG=570232
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add default ctor to SkMask

The minimal fix here seems to be handling BoxBlur's return value in
SkBlurMaskFilter.cpp::GrRRectBlurEffect::Create. We seem to do enough special
handling of the fImage field though that always initialializing it may not be a
bad idea.

BUG=570232
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2015-12-17 18:50:31]

lgtm

https://codereview.chromium.org/1539553002/diff/1/src/effects/SkBlurMask.h
File src/effects/SkBlurMask.h (right):

https://codereview.chromium.org/1539553002/diff/1/src/effects/SkBlurMask.h#ne...
src/effects/SkBlurMask.h:33: static bool BoxBlur(SkMask* dst, const SkMask& src,
Lets add SK_WARN_UNUSED_RESULT

bool SK_WARN_UNUSED_RESULT BoxBlur(...)

[robertphillips, 2015-12-17 19:14:45]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 19:14:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539553002/20001

[commit-bot: I haz the power, 2015-12-17 19:31:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 19:31:35]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-12-17 19:32:15]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-12-17 19:32:15]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1539553002/#ps20001
(title: "Add warning for ignored return values")

[commit-bot: I haz the power, 2015-12-17 19:32:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539553002/20001

[commit-bot: I haz the power, 2015-12-17 19:33:19]

Description was changed from

==========
Add default ctor to SkMask

The minimal fix here seems to be handling BoxBlur's return value in
SkBlurMaskFilter.cpp::GrRRectBlurEffect::Create. We seem to do enough special
handling of the fImage field though that always initialializing it may not be a
bad idea.

BUG=570232
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add default ctor to SkMask

The minimal fix here seems to be handling BoxBlur's return value in
SkBlurMaskFilter.cpp::GrRRectBlurEffect::Create. We seem to do enough special
handling of the fImage field though that always initialializing it may not be a
bad idea.

BUG=570232
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e80eb928ba0248a5a5dea6e1f0005aa08ecf8740
==========

[commit-bot: I haz the power, 2015-12-17 19:33:19]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e80eb928ba0248a5a5dea6e1f0005aa08ecf8740