Issue 153953011: Add git cl format presubmit warning for extension and apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153953011: Add git cl format presubmit warning for extension and apps. (Closed)

Created:
6 years, 10 months ago by scheib

Modified:
6 years, 10 months ago

Reviewers:
rpaquay

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add git cl format presubmit warning for extension and apps. Upon patch upload 'git cl format' is run on the diff and outputs a warning if the diff has style violations, saving manual review time for coding style. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249868

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -36 lines)			Patch
A +	apps/PRESUBMIT.py	View	1 chunk	+5 lines, -8 lines	0 comments	Download
A +	chrome/browser/chromeos/extensions/PRESUBMIT.py	View	1 chunk	+5 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/PRESUBMIT.py	View	1 chunk	+4 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/apps/PRESUBMIT.py	View	1 chunk	+5 lines, -8 lines	0 comments	Download
M	chrome/common/extensions/PRESUBMIT.py	View	1 chunk	+4 lines, -1 line	0 comments	Download
A +	chrome/renderer/extensions/PRESUBMIT.py	View	1 chunk	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/153953011/1

6 years, 10 months ago (2014-02-08 00:44:01 UTC) #4

Message was sent while issue was closed.

Change committed as 249868

Expand Messages | Collapse Messages