Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: chrome/common/extensions/PRESUBMIT.py

Issue 153953011: Add git cl format presubmit warning for extension and apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/apps/PRESUBMIT.py ('k') | chrome/renderer/extensions/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for changes affecting extensions. 5 """Presubmit script for changes affecting extensions.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 import fnmatch 10 import fnmatch
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 results.append(output_api.PresubmitError('IntegrationTest failed!')) 146 results.append(output_api.PresubmitError('IntegrationTest failed!'))
147 147
148 # TODO(kalman): Re-enable this check, or decide to delete it forever. Now 148 # TODO(kalman): Re-enable this check, or decide to delete it forever. Now
149 # that we have multiple directories it no longer works. 149 # that we have multiple directories it no longer works.
150 # See http://crbug.com/297178. 150 # See http://crbug.com/297178.
151 #_CheckLinks(input_api, output_api, results) 151 #_CheckLinks(input_api, output_api, results)
152 152
153 return results 153 return results
154 154
155 def CheckChangeOnUpload(input_api, output_api): 155 def CheckChangeOnUpload(input_api, output_api):
156 return _CheckChange(input_api, output_api) 156 results = []
157 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
158 results += _CheckChange(input_api, output_api)
159 return results
157 160
158 def CheckChangeOnCommit(input_api, output_api): 161 def CheckChangeOnCommit(input_api, output_api):
159 return _CheckChange(input_api, output_api) 162 return _CheckChange(input_api, output_api)
OLDNEW
« no previous file with comments | « chrome/browser/ui/apps/PRESUBMIT.py ('k') | chrome/renderer/extensions/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698