chrome/browser/extensions/PRESUBMIT.py - Issue 153953011: Add git cl format presubmit warning for extension and apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/PRESUBMIT.py

Issue 153953011: Add git cl format presubmit warning for extension and apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/PRESUBMIT.py

diff --git a/chrome/browser/extensions/PRESUBMIT.py b/chrome/browser/extensions/PRESUBMIT.py

index 8a21b4107255856cb3d0d85a3aef2200fbbe2760..c8c16b5d2987e6c2559c5680eed813189ab0bbe5 100644

--- a/chrome/browser/extensions/PRESUBMIT.py

+++ b/chrome/browser/extensions/PRESUBMIT.py

@@ -297,7 +297,8 @@ class HistogramValueChecker(object):

return self.results

def CheckChangeOnUpload(input_api, output_api):

- results = []

- results += HistogramValueChecker(input_api, output_api).Run()

- return results

+ results = []

+ results += HistogramValueChecker(input_api, output_api).Run()

+ results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

+ return results

« no previous file with comments | « chrome/browser/chromeos/extensions/PRESUBMIT.py ('k') | chrome/browser/ui/apps/PRESUBMIT.py » ('j') | no next file with comments »