Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/extensions/PRESUBMIT.py

Issue 153953011: Add git cl format presubmit warning for extension and apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chromeos/extensions/PRESUBMIT.py ('k') | chrome/browser/ui/apps/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Chromium presubmit script for src/chrome/browser/extensions. 5 """Chromium presubmit script for src/chrome/browser/extensions.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl. 8 for more details on the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 self.PerformChecks(affected_file) 290 self.PerformChecks(affected_file)
291 self.LogInfo("Done processing file \"%s\"" % affected_file.LocalPath()) 291 self.LogInfo("Done processing file \"%s\"" % affected_file.LocalPath())
292 292
293 def Run(self): 293 def Run(self):
294 for file in self.input_api.AffectedFiles(include_deletes=True): 294 for file in self.input_api.AffectedFiles(include_deletes=True):
295 if file.LocalPath() == self.LOCAL_PATH: 295 if file.LocalPath() == self.LOCAL_PATH:
296 self.ProcessHistogramValueFile(file) 296 self.ProcessHistogramValueFile(file)
297 return self.results 297 return self.results
298 298
299 def CheckChangeOnUpload(input_api, output_api): 299 def CheckChangeOnUpload(input_api, output_api):
300 results = [] 300 results = []
301 results += HistogramValueChecker(input_api, output_api).Run() 301 results += HistogramValueChecker(input_api, output_api).Run()
302 return results 302 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
303 return results
303 304
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/extensions/PRESUBMIT.py ('k') | chrome/browser/ui/apps/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698